Skip to content

drm: Ignore non-existing color planes in helpers

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v14 patches 8 repliesSuperseded

Changes in v2 from the cover letter

* refactor GEM VRAM code before fixing it (Javier)
* print more error information in #1 (Javier)
* commit-message fixes (Javier)

[1] https://lore.kernel.org/dri-devel/[email protected]/T/#md0172b10bb588d8f20f4f456e304f08d2a4505f7
[2] https://lore.kernel.org/dri-devel/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/gem: Share code between drm_gem_fb_{begin, end}_cpu_access()drivers/gpu/drm/drm_gem_framebuffer_helper.c+27 -360 replies
2/5drm/gem: Ignore color planes that are unused by framebuffer formatdrivers/gpu/drm/drm_gem_atomic_helper.c drivers/gpu/drm/drm_gem_framebuffer_helper.c include/drm/drm_gem_framebuffer_helper.h+27 -260 replies
3/5drm/gem-vram: Share code between GEM VRAM's _{prepare, cleanup}_fb()drivers/gpu/drm/drm_gem_vram_helper.c+23 -141 reply
4/5drm/gem-vram: Ignore planes that are unused by framebuffer formatdrivers/gpu/drm/drm_gem_vram_helper.c+12 -70 replies
5/5drm/gem: Warn on trying to use a non-existing framebuffer planedrivers/gpu/drm/drm_gem_framebuffer_helper.c+5 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez CanillasNoralf Trønnes
1/5R-b T-b
2/5R-b T-b
3/5R-b
4/5R-b T-b
5/5R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] drm: Ignore non-existing color planes in helpers

Some DRM helpers assume that all potential color planes of a framebuffer are available; even if the color format didn't specify them. Non-existing planes are silently ignored. This behavior is inconsistent with other helpers and apparently leads to subtle bugs with uninitialized GEM buffer mappings. [1]

Change all affected code to look at the framebuffer format's number of color planes and only process these planes. The update has been discussed in [2] before.

Tested with GEM SHMEM helpers on simpledrm and with GEM VRAM helpers on ast.

v2:
* refactor GEM VRAM code before fixing it (Javier)
* print more error information in #1 (Javier)
* commit-message fixes (Javier)

[1] https://lore.kernel.org/dri-devel/[email protected]/T/#md0172b10bb588d8f20f4f456e304f08d2a4505f7
[2] https://lore.kernel.org/dri-devel/[email protected]/

Thomas Zimmermann (5):
drm/gem: Share code between drm_gem_fb_{begin,end}_cpu_access() drm/gem: Ignore color planes that are unused by framebuffer format drm/gem-vram: Share code between GEM VRAM's _{prepare,cleanup}_fb() drm/gem-vram: Ignore planes that are unused by framebuffer format drm/gem: Warn on trying to use a non-existing framebuffer plane

 drivers/gpu/drm/drm_gem_atomic_helper.c      |   6 +-
 drivers/gpu/drm/drm_gem_framebuffer_helper.c | 104 +++++++++----------
 drivers/gpu/drm/drm_gem_vram_helper.c        |  54 ++++++----
 include/drm/drm_gem_framebuffer_helper.h     |  10 +-
 4 files changed, 92 insertions(+), 82 deletions(-)
Signature · 1 line
2.36.1