Skip to content

perf: arm64: Kernel support for Dwarf unwinding through SVE functions

James Clark linux-arm-kernel linux-doc linux-perf-users lkml 5 versions – Applied

Status from this message: Applied to will (for-next/perf), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/22 patches 9 repliesApplied
  2. v3 posting 1/25 patches 4 repliesApplied
  3. v2 posting 2/20 of 2 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/22 patches5 repliesSuperseded
v16 patches7 repliesSuperseded

Changes in v3 from the cover letter

* Add definition for PERF_REG_EXTENDED_MASK which is needed for PERF_PMU_CAP_EXTENDED_REGS to work properly

* Simplify changes to enum perf_event_arm_regs

Patches in v3 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2perf: arm64: Add SVE vector granule register to user regsarch/arm64/include/uapi/asm/perf_regs.h arch/arm64/kernel/perf_regs.c drivers/perf/arm_pmu.c+36 -30 replies
2/2arm64/sve: Add Perf extensions documentationDocumentation/arm64/sve.rst+20 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMark Brown
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] perf: arm64: Kernel support for Dwarf unwinding through SVE functions

Hi,

I'm resubmitting this with a few of the changes suggested by Will on V2.

I haven't made any changes regarding the open questions about the discoverability or saving the new reg and passing to output_sample() because I think it's best to be consistent with the implementations on other platforms first. I have explained in more detail on v2 [1].

[1]: https://lore.kernel.org/lkml/[email protected]/

=======

Changes since v2:

* Add definition for PERF_REG_EXTENDED_MASK which is needed for PERF_PMU_CAP_EXTENDED_REGS to work properly

* Simplify changes to enum perf_event_arm_regs

Changes since v1:

* Add Mark's review tag
* Clarify in docs that it's the SVE register length
* Split patchset into kernel side and Perf tool changes

=======

When SVE registers are pushed onto the stack the VG register is required to unwind because the stack offsets would vary by the SVE register width at the time when the sample was taken.

These first two patches add support for sampling the VG register to the kernel and the docs. There is another patchset to add support to userspace perf.

A small change is also required to libunwind or libdw depending on which unwinder is used, and these will be published later. Without these changes Perf continues to work with both libraries, although the VG register is still not used for unwinding.

Thanks
James

James Clark (2):
perf: arm64: Add SVE vector granule register to user regs arm64/sve: Add Perf extensions documentation

 Documentation/arm64/sve.rst             | 20 +++++++++++++++++
 arch/arm64/include/uapi/asm/perf_regs.h |  7 ++++++
 arch/arm64/kernel/perf_regs.c           | 30 +++++++++++++++++++++++--
 drivers/perf/arm_pmu.c                  |  2 +-
 4 files changed, 56 insertions(+), 3 deletions(-)
Signature · 1 line
2.28.0