Skip to content

s390/net: Cleanup some code checker findings

Alexandra Winter linux-s390 netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3s390/ctcm: fix variable dereferenced before checkdrivers/s390/net/ctcm_sysfs.c+3 -20 repliesApplied
2/3s390/ctcm: fix potential memory leakdrivers/s390/net/ctcm_mpc.c+1 -50 repliesApplied
3/3s390/lcs: fix variable dereferenced before checkdrivers/s390/net/lcs.c+4 -30 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net 0/3] s390/net: Cleanup some code checker findings

clean up smatch findings in legacy code. I was not able to provoke any real failures on my systems, but other hardware reactions, timing conditions or compiler output, may cause failures.

There are still 2 smatch warnings left in s390/net:

drivers/s390/net/ctcm_main.c:1326 add_channel() warn: missing error code 'rc' This one is a false positive.

drivers/s390/net/netiucv.c:1355 netiucv_check_user() warn: argument 3 to %02x specifier has type 'char' Postponing this one, need to better understand string handling in iucv.

There are several sparse warnings left in ctcm, like:
drivers/s390/net/ctcm_fsms.c:573:9: warning: context imbalance in 'ctcm_chx_setmode' - different lock contexts for basic block Those are mentioned in the source, no plan to rework.

Alexandra Winter (3):
s390/ctcm: fix variable dereferenced before check s390/ctcm: fix potential memory leak s390/lcs: fix variable dereferenced before check

 drivers/s390/net/ctcm_mpc.c   | 6 +-----
 drivers/s390/net/ctcm_sysfs.c | 5 +++--
 drivers/s390/net/lcs.c        | 7 ++++---
 3 files changed, 8 insertions(+), 10 deletions(-)
Signature · 1 line
2.32.0