Skip to content

Clear TLB caches in all tiles when object is removed

Andi Shyti dri-devel intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v23 patches 0 repliesSuperseded

Changes in v4 from the cover letter

- Fix e-mail mismatch in author and in SoB (Sorry!).

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/gt: Ignore TLB invalidations on idle enginesdrivers/gpu/drm/i915/gt/intel_gt_pm.h+4 -01 reply
2/3drm/i915/gem: Flush TLBs for all the tiles when clearing an objdrivers/gpu/drm/i915/gem/i915_gem_pages.c+9 -30 replies
3/3drm/i915/gt: Skip TLB invalidation if the engine is not awakedrivers/gpu/drm/i915/gt/intel_gt.c+4 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] Clear TLB caches in all tiles when object is removed

Hi,

Maybe I should not send patches this late at night as I end up messing things up and spamming sleeping people. Sorry for this version 4.

The real fix is in patch 2. The rest is a helper that adds the with_intel_gt_pm_if_awake() (from Chris) and one more check on the status of the engine before accessing it for clearing the TLB.

Andi

Changelog
=========
v3 -> v4
- Fix e-mail mismatch in author and in SoB (Sorry!).

v2 -> v3 (v2: https://patchwork.freedesktop.org/series/103835/)
- Add missing header file that was causing a compmile error.
- Fix wrong patch formatting.

v1 -> v2 (v1: https://patchwork.freedesktop.org/series/103831/)
- Add with_intel_gt_pm_if_awake() macro for gt specific wakeref.
- Check if an engine is awake before invalidating its TLB.

Andi Shyti (2):
drm/i915/gem: Flush TLBs for all the tiles when clearing an obj drm/i915/gt: Skip TLB invalidation if the engine is not awake

Chris Wilson (1):
drm/i915/gt: Ignore TLB invalidations on idle engines

 drivers/gpu/drm/i915/gem/i915_gem_pages.c | 12 +++++++++---
 drivers/gpu/drm/i915/gt/intel_gt.c        |  4 ++++
 drivers/gpu/drm/i915/gt/intel_gt_pm.h     |  4 ++++
 3 files changed, 17 insertions(+), 3 deletions(-)
Signature · 1 line
2.36.1