Skip to content

Fixes for fanotify parent dir ignore mask logic

Amir Goldstein linux-fsdevel stable 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 6 repliesIn review
  2. v12 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Change hacky mark iterator macros
- Clarify mark iterator in fsnotify_iter_next()
- Open code parent mark type logic in
fsnotify_iter_select_report_types()

[1] https://github.com/amir73il/linux/commits/fan_mark_ignore
[2] https://github.com/amir73il/ltp/commits/fan_mark_ignore
[3] https://github.com/amir73il/man-pages/commits/fan_mark_ignore

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fsnotify: introduce mark type iteratorfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c include/linux/fsnotify_backend.h+54 -440 replies
2/2fsnotify: consistent behavior for parent not watching childrenfs/notify/fanotify/fanotify.c fs/notify/fsnotify.c+20 -245 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fixes for fanotify parent dir ignore mask logic

Jan,

The following two patches are a prelude to FAN_MARK_IGNORE patch set [1]. I have written tests [2] and man page draft [3] for FAN_MARK_IGNORE, but not proposing it for next, because one big UAPI change is enough and it is too late in the cycle anyway.

However, I though you may want to consider these two patches for next. The test fanotify09 on [2] has two new test cases for the fixes in these patches.

Thanks,
Amir.

Changes since v1:
- Change hacky mark iterator macros
- Clarify mark iterator in fsnotify_iter_next()
- Open code parent mark type logic in
fsnotify_iter_select_report_types()

[1] https://github.com/amir73il/linux/commits/fan_mark_ignore
[2] https://github.com/amir73il/ltp/commits/fan_mark_ignore
[3] https://github.com/amir73il/man-pages/commits/fan_mark_ignore

Amir Goldstein (2):
fsnotify: introduce mark type iterator
fsnotify: consistent behavior for parent not watching children

 fs/notify/fanotify/fanotify.c    | 24 ++-------
 fs/notify/fsnotify.c             | 85 +++++++++++++++++---------------
 include/linux/fsnotify_backend.h | 31 +++++++++---
 3 files changed, 73 insertions(+), 67 deletions(-)
Signature · 1 line
2.25.1