Vendor agnostic gputop
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 2 repliesIn review
v2 from the cover letter
* Fixed SPDX headers and added a bunch of code comments/docs throughout.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | lib: Extract igt_drm_clients from intel_gpu_toplib/ lib/ lib/ +2 more | +593 | 0 replies | |
| 2/8 | libdrmfdinfo: Allow specifying custom engine maplib/ lib/ lib/ +3 more | +86 | 0 replies | |
| 3/8 | libdrmclients: Record client drm minorlib/ lib/ | +15 | 0 replies | |
| 4/8 | libdrmclient: Support multiple DRM cardslib/ | +8 | 0 replies | |
| 5/8 | libdrmfdinfo: Track largest engine indexlib/ lib/ | +3 | 0 replies | |
| 6/8 | libdrmclient/intel_gpu_top: Decouple hardcoded engine assumptionslib/ lib/ tools/ | +120 | 0 replies | |
| 7/8 | libdrmclient: Enforce client status sort order in the librarylib/ lib/ tools/ | +65 | 0 replies | |
| 8/8 | gputop: Basic vendor agnostic GPU top tooltools/ tools/ | +265 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [igt-dev] [PATCH i-g-t 0/8] Vendor agnostic gputop
From: Tvrtko Ursulin <[email protected]>
This is a pile of patches which implements a rudimentary vendor agnostic gputop tool based of the new DRM spec as documented in Documentation/gpu/drm-usage-stats.rst.
First part of the series is code refactoring which should be reasonably stable. I've tested it all while working on it both against intel_gpu_top and gputop.
Last patch is the actual tool itself. It works but it is rather rudimentary which is hopefully good enough for a start.
Fundamental difference between intel_gpu_top and gputop is that the former is centered around a single card and only shows processes belonging to it. Gputop on the other hand has an idea to show all processes with DRM file descriptors open and sort them into groups per card. It also makes no effort to provide sorting modes, well any interactivity, or any pretty names for GPUs or engines.
It looks like this:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DRM minor 0
PID NAME render copy video
3816 kwin_x11 |███▎ || || || |
3523 Xorg |▊ || || || |
1120449 mpv | || ||▋ || |
1120529 glxgears |▋ || || || |
1120449 mpv |▍ || || || |
3860 plasmashell |▏ || || || |
4764 krunner | || || || |
575206 chrome | || || || |
833481 firefox | || || || |
892924 thunderbird | || || || |~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I did test it as well with two cards and confirmed that too works.
Rob Clark also tested it with a patch which exports the respective data from the msm driver and confirmed it works fine. Christian König tested it with in progress patches for amdgpu and that worked as well.
v2:
* Fixed SPDX headers and added a bunch of code comments/docs throughout.
Tvrtko Ursulin (8):
lib: Extract igt_drm_clients from intel_gpu_top
libdrmfdinfo: Allow specifying custom engine map
libdrmclients: Record client drm minor
libdrmclient: Support multiple DRM cards
libdrmfdinfo: Track largest engine index libdrmclient/intel_gpu_top: Decouple hardcoded engine assumptions
libdrmclient: Enforce client status sort order in the library
gputop: Basic vendor agnostic GPU top tool
lib/igt_drm_clients.c | 495 ++++++++++++++++++++++++++++++ lib/igt_drm_clients.h | 87 ++++++ lib/igt_drm_fdinfo.c | 50 ++- lib/igt_drm_fdinfo.h | 16 +- lib/meson.build | 8 + tests/i915/drm_fdinfo.c | 18 +- tools/gputop.c | 260 ++++++++++++++++ tools/intel_gpu_top.c | 663 ++++++++++------------------------------ tools/meson.build | 7 +- 9 files changed, 1085 insertions(+), 519 deletions(-) create mode 100644 lib/igt_drm_clients.c create mode 100644 lib/igt_drm_clients.h create mode 100644 tools/gputop.c
Signature · 1 line
2.32.0