Skip to content

hwmon: Introduce and use hwmon_device_register_for_thermal

Guenter Roeck linux-hwmon linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hwmon: Introduce hwmon_device_register_for_thermaldrivers/hwmon/hwmon.c include/linux/hwmon.h+28 -00 replies
2/3thermal/drivers/thermal_hwmon: Use hwmon_device_register_for_thermal()drivers/thermal/thermal_hwmon.c+4 -20 replies
3/3hwmon: Make chip parameter for with_info API mandatoryDocumentation/hwmon/hwmon-kernel-api.rst drivers/hwmon/hwmon.c+8 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] hwmon: Introduce and use hwmon_device_register_for_thermal

The thermal subsystem registers a hwmon driver without providing chip information or sysfs group information. This is for legacy reasons and would be difficult to change.

At the same time, several attempts have been made to convert hwmon drivers using the deprecated hwmon_device_register() to use hwmon_device_register_with_info() by just providing NULL parameters. This is an abuse of the hwmon API. To prevent this abuse, we want to enforce that a parent device pointer as well as chip information is provided when registering a hwmon device using hwmon_device_register_with_info().

To be able to do this, introduce and use a special API for use only by the thermal subsystem (patches 1 and 2). Patch 3 makes the 'dev' and 'chip' parameters of hwmon_device_register_with_info() mandatory.

----------------------------------------------------------------
Guenter Roeck (3):
hwmon: Introduce hwmon_device_register_for_thermal thermal/drivers/thermal_hwmon: Use hwmon_device_register_for_thermal()
hwmon: Make chip parameter for with_info API mandatory

 Documentation/hwmon/hwmon-kernel-api.rst |  2 +-
 drivers/hwmon/hwmon.c                    | 41 ++++++++++++++++++++++++++++++++---------
 drivers/thermal/thermal_hwmon.c          |  6 ++++--
 include/linux/hwmon.h                    |  3 +++
 4 files changed, 40 insertions(+), 12 deletions(-)