Skip to content

ui: Remove deprecated sdl parameters and switch to QAPI parser

Thomas Huth qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 4 repliesIn review
  2. v23 patches 15 repliesSuperseded
  3. v13 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Fixed some texts according to Markus' and Eric's suggestions
- Renamed the GrabMod enum to HotKeyMod (to not confuse it so easily with GrabToggleKeys)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ui: Remove deprecated parameters of the "-display sdl" optiondocs/about/deprecated.rst docs/about/removed-features.rst qemu-options.hx +1 more+20 -860 replies
2/3ui: Switch "-display sdl" to use the QAPI parserinclude/sysemu/sysemu.h qapi/ui.json softmmu/globals.c +2 more+36 -744 replies
3/3ui: Remove deprecated options "-sdl" and "-curses"docs/about/deprecated.rst docs/about/removed-features.rst qemu-options.hx +1 more+12 -510 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéMarkus Armbruster
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser

The "-display sdl" option still uses a hand-crafted parser for its parameters since some of them used underscores which is disliked in QAPI. Now that they've been deprecated and the deprecation period is over, we can remove the problematic parameters and switch to use the QAPI parser instead.

While we're at it, also remove the deprecated "-sdl" and "-curses" options.

v3:
- Fixed some texts according to Markus' and Eric's suggestions
- Renamed the GrabMod enum to HotKeyMod (to not confuse it so easily with GrabToggleKeys)

v2:
- Rebase to current master branch to resolve conflicts in docs/about/*.rst
- Use an enum for the grab-mod parameter instead of a unconstrained string

Thomas Huth (3):
ui: Remove deprecated parameters of the "-display sdl" option
ui: Switch "-display sdl" to use the QAPI parser
ui: Remove deprecated options "-sdl" and "-curses"

 docs/about/deprecated.rst       |  26 -------
 docs/about/removed-features.rst |  27 +++++++
 qapi/ui.json                    |  26 ++++++-
 include/sysemu/sysemu.h         |   2 -
 softmmu/globals.c               |   2 -
 softmmu/vl.c                    | 128 +-------------------------------
 ui/sdl2.c                       |  10 +++
 qemu-options.hx                 |  56 +-------------
 8 files changed, 67 insertions(+), 210 deletions(-)
Signature · 1 line
2.27.0