iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest2 patches 3 repliesIn review
- v72 patches 2 repliesSuperseded
- v62 patches 1 replySuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 2 patches | 3 replies | Superseded | |
| v4 | 2 patches | 9 replies | Superseded | |
| v3 | 2 patches | 3 replies | Superseded | |
| v2 | 2 patches | 3 replies | Superseded | |
| v1 | 1 patch | 3 replies | Superseded |
Changes in v8 from the cover letter
- Condense the code a bit by dropping rc2
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | iio: pressure: dps310: Refactor startup proceduredrivers/ | +99 | 0 replies | |
| 2/2 | iio: pressure: dps310: Reset chip after timeoutdrivers/ | +64 | 3 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Joel Stanley | Andy Shevchenko |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 0/2] iio: pressure: dps310: Reset chip if MEAS_CFG is corrupt
The DPS310 chip has been observed to get "stuck" such that pressure and temperature measurements are never indicated as "ready" in the MEAS_CFG register. The only solution is to reset the device and try again. In order to avoid continual failures, use a boolean flag to only try the reset after timeout once if errors persist. Include a patch to move the startup procedure into a function.
Changes since v7:
- Condense the code a bit by dropping rc2
Changes since v6:
- Use helper instead of the lengthy regmap_read_poll_timeout twice
- Just return dps310_startup in dps310_reset_reinit
Changes since v5:
- Completely rework the second patch to reset and reinit in any timeout condition, if there haven't been previous timeouts that failed to recover the chip.
Changes since v4:
- Just check for rc rather than rc < 0 in some cases
- Split declaration and init of rc
Changes since v3:
- Don't check regmap* return codes for < 0
- Fix comment spelling
Changes since v2:
- Add some comments
- Fix the clunky control flow
Changes since v1:
- Separate into two patches
- Rename 'dps310_verify_meas_cfg' to 'dps310_check_reset_meas_cfg'
Eddie James (2):
iio: pressure: dps310: Refactor startup procedure
iio: pressure: dps310: Reset chip after timeout
drivers/iio/pressure/dps310.c | 262 +++++++++++++++++++++------------- 1 file changed, 163 insertions(+), 99 deletions(-)
Signature · 1 line
2.31.1