Skip to content

platform/chrome: get rid of BUG_ON()

Tzung-Bi Shih chrome-platform lkml 2 versions – Applied

Status from this message: This series was applied to chrome-platform/linux.git (for-kernelci)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesApplied 7/7
  2. v16 patches 7 repliesSuperseded

Changes in v2 from the cover letter

(https://patchwork.kernel.org/project/chrome-platform/cover/[email protected]/)
- Split the original 6th patch into 2 smaller patches.

Patches in v2 All 7 applied

#Subject and filesSizeRepliesApplied
1/7platform/chrome: cros_ec_proto: drop unneeded BUG_ON() in prepare_packet()drivers/platform/chrome/cros_ec_proto.c+0 -10 repliesApplied
2/7platform/chrome: correct cros_ec_prepare_tx() usagedrivers/platform/chrome/cros_ec_i2c.c drivers/platform/chrome/cros_ec_ishtp.c drivers/platform/chrome/cros_ec_lpc.c +3 more+14 -20 repliesApplied
3/7platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx()drivers/platform/chrome/cros_ec_proto.c+5 -20 repliesApplied
4/7platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_get_host_event()drivers/platform/chrome/cros_ec_proto.c+2 -10 repliesApplied
5/7platform/chrome: cros_ec_i2c: drop BUG_ON() in cros_ec_pkt_xfer_i2c()drivers/platform/chrome/cros_ec_i2c.c+8 -20 repliesApplied
6/7platform/chrome: cros_ec_spi: drop unneeded BUG_ON()drivers/platform/chrome/cros_ec_spi.c+0 -21 replyApplied
7/7platform/chrome: cros_ec_spi: drop BUG_ON() if `din` isn't large enoughdrivers/platform/chrome/cros_ec_spi.c+6 -31 replyApplied

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] platform/chrome: get rid of BUG_ON()

The series gets rid of BUG_ON()s in drivers/platform/chrome/. Most of them can be replaced by returning proper return code.

The 2nd patch makes callers of cros_ec_prepare_tx() to take care of the return code.

The 3rd patch turns cros_ec_prepare_tx() to return error code if any.

Changes from v1:
(https://patchwork.kernel.org/project/chrome-platform/cover/[email protected]/)
- Split the original 6th patch into 2 smaller patches.

Tzung-Bi Shih (7):
platform/chrome: cros_ec_proto: drop unneeded BUG_ON() in
prepare_packet()
platform/chrome: correct cros_ec_prepare_tx() usage platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx() platform/chrome: cros_ec_proto: drop BUG_ON() in
cros_ec_get_host_event()
platform/chrome: cros_ec_i2c: drop BUG_ON() in cros_ec_pkt_xfer_i2c() platform/chrome: cros_ec_spi: drop unneeded BUG_ON() platform/chrome: cros_ec_spi: drop BUG_ON() if din isn't large
enough

 drivers/platform/chrome/cros_ec_i2c.c   | 12 ++++++++++--
 drivers/platform/chrome/cros_ec_ishtp.c |  4 +++-
 drivers/platform/chrome/cros_ec_lpc.c   |  2 ++
 drivers/platform/chrome/cros_ec_proto.c | 13 ++++++++-----
 drivers/platform/chrome/cros_ec_rpmsg.c |  2 ++
 drivers/platform/chrome/cros_ec_spi.c   | 15 ++++++++++-----
 6 files changed, 35 insertions(+), 13 deletions(-)
Signature · 1 line
2.36.0.550.gb090851708-goog