Skip to content

Improve OpenSSL 3.0 support in OpenVPN 2.5

Arne Schwabe openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Refactor early initialisation and uninitialisation into methodssrc/openvpn/openvpn.c+18 -51 reply
2/7Allow loading of non default providersChanges.rst doc/man-sections/generic-options.rst src/openvpn/crypto_backend.h +7 more+130 -11 reply
3/7Add ubuntu 22.04 to Github Actions.github/workflows/build.yaml+5 -11 reply
4/7Add macos OpenSSL 3.0 and ASAN builds.github/workflows/build.yaml+25 -31 reply
5/7Add --with-openssl-engine autoconf option (auto|yes|no)Changes.rst configure.ac+50 -131 reply
6/7Fix allowing/showing unsupported ciphers and digestssrc/openvpn/crypto_openssl.c+47 -31 reply
7/7Remove dependency on BF-CBC existance from test_ncptests/unit_tests/openvpn/test_ncp.c+8 -21 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGert DoeringMax Fillinger
SeriesA-b
1/7A-b
2/7A-b
3/7A-b A-b
4/7A-b A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/7] Improve OpenSSL 3.0 support in OpenVPN 2.5

We already see distros shipping 2.5 with OpenSSL 3.0 and while it builds and works, there are number of problems. This patch addresses most of them while not backporting the full refactoring that also allows using ciphers and digests from providers that were not present in OpenSSL itself. Also the patches that allow a build and make check to suceed with OpenSSL 3.0 have been backported.

Most of the commits are cherry-picked from master with small changes were needed. The exception is the

From Changes.rst:

Limited OpenSSL 3.0 support
OpenSSL 3.0 support has been added. OpenSSL 3.0 support in 2.5 relies on the compatiblity layer and full OpenSSL 3.0 support is coming with OpenVPN 2.6. Only features that impact usage directly have been backported:

``--tls-cert-profile insecure`` has been added to allow selecting the lowest OpenSSL security level (not recommended, use only if you must).

OpenSSL 3.0 no longer supports the Blowfish (and other deprecated) algorithm by default and the new option ``--providers`` allows loading the legacy provider to renable these algorithms.

The OpenSSL engine feature ``--engine`` is not enabled by default anymore if OpenSSL 3.0 is detected.

Arne Schwabe (7):
Refactor early initialisation and uninitialisation into methods Allow loading of non default providers
Add ubuntu 22.04 to Github Actions
Add macos OpenSSL 3.0 and ASAN builds
Add --with-openssl-engine autoconf option (auto|yes|no) Fix allowing/showing unsupported ciphers and digests Remove dependency on BF-CBC existance from test_ncp

 .github/workflows/build.yaml         | 34 ++++++++++--
 Changes.rst                          | 17 ++++++
 configure.ac                         | 60 ++++++++++++++++-----
 doc/man-sections/generic-options.rst | 12 +++++
 src/openvpn/crypto_backend.h         | 15 ++++++
 src/openvpn/crypto_mbedtls.c         | 13 +++++
 src/openvpn/crypto_mbedtls.h         |  3 ++
 src/openvpn/crypto_openssl.c         | 81 ++++++++++++++++++++++++++--
 src/openvpn/crypto_openssl.h         | 11 ++++
 src/openvpn/openvpn.c                | 36 +++++++++++--
 src/openvpn/options.c                |  8 +++
 src/openvpn/options.h                |  9 ++++
 tests/unit_tests/openvpn/test_ncp.c  | 10 +++-
 13 files changed, 282 insertions(+), 27 deletions(-)
Signature · 1 line
2.32.0 (Apple Git-132)