Skip to content

hw: aspeed: Init all UART's with serial devices

Peter Delevoryas openbmc qemu-arm qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesIn review
  2. v12 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- Rebased on Cedric's irq proposal. [1]
- Added "Introduce common UART init function" patch
- Added "Add uarts_num SoC attribute" patch
- Rewrote last commit's message for clarity

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw: aspeed: Add missing UART'shw/arm/aspeed_ast10x0.c hw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c +1 more+57 -01 reply
2/5hw: aspeed: Add uarts_num SoC attributehw/arm/aspeed_ast10x0.c hw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c +1 more+5 -01 reply
3/5hw: aspeed: Ensure AST1030 respects uart-defaulthw/arm/aspeed_ast10x0.c+3 -31 reply
4/5hw: aspeed: Introduce common UART init functionhw/arm/aspeed_ast10x0.c hw/arm/aspeed_ast2600.c hw/arm/aspeed_soc.c +1 more+17 -141 reply
5/5hw: aspeed: Init all UART's with serial deviceshw/arm/aspeed_soc.c+9 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchCédric Le Goater
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] hw: aspeed: Init all UART's with serial devices

v2:
- Rebased on Cedric's irq proposal. [1]
- Added "Introduce common UART init function" patch
- Added "Add uarts_num SoC attribute" patch
- Rewrote last commit's message for clarity

I tried testing this by running acceptance tests, particularly the boot_linux_console.py file, but I had to disable the raspi2_initrd case. It's not related to my changes (A/B tested and it fails on upstream/master too), but thought I would mention that.

I also manually tested several machines:

AST2400: https://github.com/facebook/openbmc/releases/download/v2021.49.0/wedge100.mtd
AST2500: https://github.com/facebook/openbmc/releases/download/v2021.49.0/fby3.mtd
AST2600: https://github.com/facebook/openbmc/releases/download/v2021.49.0/fuji.mtd
AST1030: https://github.com/peterdelevoryas/OpenBIC/releases/download/oby35-cl-2022.13.01/Y35BCL.elf

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Peter Delevoryas (5):
hw: aspeed: Add missing UART's
hw: aspeed: Add uarts_num SoC attribute
hw: aspeed: Ensure AST1030 respects uart-default
hw: aspeed: Introduce common UART init function
hw: aspeed: Init all UART's with serial devices

 hw/arm/aspeed_ast10x0.c     | 32 +++++++++++++++++++++++++++-----
 hw/arm/aspeed_ast2600.c     | 27 ++++++++++++++++++++++-----
 hw/arm/aspeed_soc.c         | 33 +++++++++++++++++++++++++++++----
 include/hw/arm/aspeed_soc.h | 10 ++++++++++
 4 files changed, 88 insertions(+), 14 deletions(-)
Signature · 1 line
2.30.2