Skip to content

Split driver specific commands out of testpmd

David Marchand dpdk-dev 3 versions – Applied

Status from this message: Applied to dpdk-next-net/main, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 5 repliesApplied
  2. v2 RFC posting 1/25 patches 4 repliesSuperseded
  3. v1 RFC4 patches 10 repliesSuperseded

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/2app/testpmd: mark most cmdline symbols as staticapp/test-pmd/bpf_cmd.c app/test-pmd/cmdline.c app/test-pmd/cmdline_flow.c +2 more+1725 -17401 reply
2/2app/testpmd: register driver specific commandsapp/test-pmd/cmdline.c app/test-pmd/meson.build app/test-pmd/testpmd.c +4 more+122 -173 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCristian DumitrescuFerruh YigitThomas MonjalonAndrew Rybchenko
1/2A-b A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] Split driver specific commands out of testpmd

Hello,

Following TB decision [1] and recent discussions on the driver specific commands in testpmd, here is a proposal on how the split could be done.

For now, this series simply moves the testpmd code in the driver directory. The driver specific testpmd code is still compiled as part of testpmd compilation via a global meson testpmd_driver_sources list.

1: https://mails.dpdk.org/archives/dev/2022-April/239191.html

Signature · 38 lines
David Marchand

Changes since v1:
- dropped drivers updates,
- handled comments on testpmd API,

Changes since RFC v2:
- extended cleanup patch 1,
- fixed command registration (again..),
- dropped ixgbe bypass commands,
- fixed some indent,
- updated documentation,

Changes since RFC v1:
- added a cleanup as patch 1, to make all parser symbols static,
- fixed registering issue in patch 1,
- moved more i40e specific commands, fixed checkpatch warnings,


David Marchand (2):
  app/testpmd: mark most cmdline symbols as static
  app/testpmd: register driver specific commands

 app/test-pmd/bpf_cmd.c                      |   20 +-
 app/test-pmd/cmdline.c                      | 2847 ++++++++++---------
 app/test-pmd/cmdline_flow.c                 |    8 +-
 app/test-pmd/cmdline_mtr.c                  |  219 +-
 app/test-pmd/cmdline_tm.c                   |  442 +--
 app/test-pmd/meson.build                    |    5 +
 app/test-pmd/testpmd.c                      |    4 +
 app/test-pmd/testpmd.h                      |   23 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   27 +-
 drivers/meson.build                         |    5 +
 meson.build                                 |    2 +
 11 files changed, 1846 insertions(+), 1756 deletions(-)

-- 
2.36.1