Several perf metrics topdown related fixes
Status from this message: Thanks, applied.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 3 repliesApplied
- v24 patches 5 repliesSuperseded
- v14 patches 8 repliesSuperseded
Changes in v3 from the cover letter
- Add more comments for the evsel__sys_has_perf_metrics() and topdown_sys_has_perf_metrics()
- Remove the uncessary evsel->core.leader->nr_members = 0; in patch 2. The value has been updated in the new evsel__remove_from_group().
- Add Reviewed-by from Ian for patch 4
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | perf evsel: Fixes topdown events in a weak group for the hybrid platformtools/ | +21 | 1 reply | |
| 2/4 | perf stat: Always keep perf metrics topdown events in a grouptools/ tools/ tools/ +1 more | +15 | 1 reply | |
| 3/4 | perf parse-events: Support different format of the topdown event nametools/ | +1 | 0 replies | |
| 4/4 | perf parse-events: Move slots event for the hybrid platform tootools/ tools/ tools/ | +35 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Ian Rogers |
|---|---|
| 1/4 | A-b |
| 2/4 | A-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH V3 0/4] Several perf metrics topdown related fixes
From: Kan Liang <[email protected]>
The Patch 1 is a follow-up patch for Ian's ("Fix topdown event weak grouping")[1].
The patch 2 is to fix the perf metrics topdown events in a mixed group. It reuses the function introduced in [1].
Patch 1 & 2 should be on top of [1].
The patch 3 & 4 are to fix other perf metrics topdown related issues. They can be merged separately.
[1]: https://lore.kernel.org/all/[email protected]/
Changes since V2:
- Add more comments for the evsel__sys_has_perf_metrics() and topdown_sys_has_perf_metrics()
- Remove the uncessary evsel->core.leader->nr_members = 0; in patch 2. The value has been updated in the new evsel__remove_from_group().
- Add Reviewed-by from Ian for patch 4
Changes since V1:
- Add comments for the evsel__sys_has_perf_metrics() and topdown_sys_has_perf_metrics()
- Factor out evsel__remove_from_group()
- Add Reviewed-by from Ian for patch 3
Kan Liang (4):
perf evsel: Fixes topdown events in a weak group for the hybrid
platform
perf stat: Always keep perf metrics topdown events in a group perf parse-events: Support different format of the topdown event name perf parse-events: Move slots event for the hybrid platform too
tools/perf/arch/x86/util/evlist.c | 7 ++++--- tools/perf/arch/x86/util/evsel.c | 23 +++++++++++++++++++++-- tools/perf/arch/x86/util/topdown.c | 25 +++++++++++++++++++++++++ tools/perf/arch/x86/util/topdown.h | 7 +++++++ tools/perf/builtin-stat.c | 7 ++----- tools/perf/util/evlist.c | 6 +----- tools/perf/util/evsel.c | 13 +++++++++++-- tools/perf/util/evsel.h | 2 +- 8 files changed, 72 insertions(+), 18 deletions(-) create mode 100644 tools/perf/arch/x86/util/topdown.h
Signature · 1 line
2.35.1