Skip to content

memcontrol selftests fixups

Michal Koutný cgroups linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4selftests: memcg: Fix compilationtools/testing/selftests/cgroup/test_memcontrol.c+14 -113 replies
2/4selftests: memcg: Expect no low events in unprotected siblingtools/testing/selftests/cgroup/test_memcontrol.c+1 -13 replies
3/4selftests: memcg: Adjust expected reclaim values of protected cgroupstools/testing/selftests/cgroup/test_memcontrol.c+10 -101 reply
4/4selftests: memcg: Remove protection from top level memcgtools/testing/selftests/cgroup/test_memcontrol.c+4 -85 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchDavid VernetRoman Gushchin
1/4R-b A-b
2/4R-b
3/4
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] memcontrol selftests fixups

Hello.

I'm just flushing the simple patches to make memcontrol selftests check the events behavior we had consensus about (test_memcg_low fails). (I've dropped to goto macros for now.)

(test_memcg_reclaim, test_memcg_swap_max fail for me now but it's present even before the refactoring.)

The only bigger change is adjustment of the protected values to make tests succeed with the given tolerance.

It's based on mm-stable [1] commit e240ac52f7da. AFAIC, the fixup and partial reverts may be folded into respective commits.
Let me know if it should be (re)based on something else.

Thanks,
Michal

[1] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/log/tools/testing/selftests/cgroup?h=mm-stable

Michal Koutný (4):
selftests: memcg: Fix compilation
selftests: memcg: Expect no low events in unprotected sibling
selftests: memcg: Adjust expected reclaim values of protected cgroups
selftests: memcg: Remove protection from top level memcg

 .../selftests/cgroup/test_memcontrol.c        | 59 +++++++++----------
 1 file changed, 29 insertions(+), 30 deletions(-)
Signature · 1 line
2.35.3