Skip to content

KVM: x86/mmu: nEPT X-only unsync bug fix

Sean Christopherson kvm lkml 1 version Applied

Status from this message: Queued, thanks. Here is the new message for patch 1:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2KVM: x86/mmu: Drop RWX=0 SPTEs during ept_sync_page()arch/x86/kvm/mmu/paging_tmpl.h arch/x86/kvm/mmu/spte.c+10 -14 replies
2/2KVM: x86/mmu: Comment FNAME(sync_page) to document TLB flushing logicarch/x86/kvm/mmu/paging_tmpl.h+9 -01 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJim Mattson
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] KVM: x86/mmu: nEPT X-only unsync bug fix

Fix a contrived bug where KVM can create a shadow-present SPTE with RWX=0 if L1 modifies an existing RX or RWX 4kb SPTE to be X-only and the combined permissions for the upper level SPTEs yield !X.

Patch 2 adds a comment explaining why FNAME(sync_page) isn't repsonsible for flushing synchronized entries that reduce protections, e.g. drop X (or add NX). Lack of a flush made me do a double-take and a lot of staring.

Sean Christopherson (2):
KVM: x86/mmu: Drop RWX=0 SPTEs during ept_sync_page()
KVM: x86/mmu: Comment FNAME(sync_page) to document TLB flushing logic

 arch/x86/kvm/mmu/paging_tmpl.h | 18 +++++++++++++++++-
 arch/x86/kvm/mmu/spte.c        |  2 ++
 2 files changed, 19 insertions(+), 1 deletion(-)

base-commit: 2764011106d0436cb44702cfb0981339d68c3509

Signature · 1 line
2.36.0.550.gb090851708-goog