Skip to content

net: polish skb defer freeing

Eric Dumazet netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4net: fix possible race in skb_attempt_defer_free()include/linux/netdevice.h net/core/dev.c net/core/skbuff.c+8 -53 repliesApplied
2/4net: use napi_consume_skb() in skb_defer_free_flush()net/core/dev.c+1 -10 repliesApplied
3/4net: add skb_defer_max sysctlDocumentation/admin-guide/sysctl/net.rst net/core/dev.c net/core/dev.h +2 more+27 -72 repliesApplied
4/4net: call skb_defer_free_flush() before each napi_poll()net/core/dev.c+3 -23 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] net: polish skb defer freeing

From: Eric Dumazet <[email protected]>

While testing this recently added feature on a variety of platforms/configurations, I found the following issues:

1) A race leading to concurrent calls to smp_call_function_single_async()

2) Missed opportunity to use napi_consume_skb()

3) Need to limit the max length of the per-cpu lists.

4) Process the per-cpu list more frequently, for the (unusual) case where net_rx_action() has mutiple napi_poll() to process per round.

Eric Dumazet (4):
net: fix possible race in skb_attempt_defer_free()
net: use napi_consume_skb() in skb_defer_free_flush()
net: add skb_defer_max sysctl
net: call skb_defer_free_flush() before each napi_poll()

 Documentation/admin-guide/sysctl/net.rst |  8 ++++++++
 include/linux/netdevice.h                |  1 +
 net/core/dev.c                           | 15 ++++++++++-----
 net/core/dev.h                           |  2 +-
 net/core/skbuff.c                        | 18 ++++++++++--------
 net/core/sysctl_net_core.c               |  8 ++++++++
 6 files changed, 38 insertions(+), 14 deletions(-)
Signature · 1 line
2.36.0.550.gb090851708-goog