Skip to content

fstests: fixes and more fixes...

Dave Chinner fstests 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest0 of 13 patches 3 repliesIn review
  2. v10 of 3 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

None of the 13 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchDarrick J. WongZorro Lang
SeriesR-b R-b R-b R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 00/13 V2] fstests: fixes and more fixes...

Hi folks,

This is a rollup of the two patch series I sent yesterday titled:

[PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods [PATCH 0/3] fstests: more fixes...

I've fixed some patches, added documentation for those changes, and added a bunch of patches to remove deprecated/broken tests that should ahve been removed long ago.

I do not know if patches 9-11 will make it through vger this time - they didn't as a single patch. They are titled:

[PATCH 09/12] xfs/018: remove deprecated test
[PATCH 10/12] xfs/081: remove deprecated test
[PATCH 11/12] xfs/082: remove deprecated test

and is thould be pretty obvious what they do from the title....

As for:

[PATCH 04/12] fstests: fix group list generation for whacky test

I've updated it to use $VALID_TEST_NAME so that it doesn't miss names like xfs/191-input_validation as can be seen here:

$ sudo MOUNT_OPTIONS= ./check -b -s xfs -n -g mkfs
SECTION       -- xfs
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test2 5.18.0-rc7-dgc+ #1245 SMP PREEMPT_DYNAMIC Mon May 16 11:51:16 AEST 2022
MKFS_OPTIONS  -- -f -m rmapbt=1 /dev/vdb
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch

generic/405
shared/032
xfs/019
xfs/029
xfs/031
xfs/096
xfs/178
xfs/191-input-validation
xfs/260
xfs/279
xfs/284
xfs/292
xfs/419
xfs/500
xfs/504
xfs/522
xfs/523
xfs/524
xfs/525
xfs/526
xfs/543

And I've document the use of _begin_fstests by the build infrastructure and the constraints that introduces into it's definition in the README file section that documents how to define test groups for a given test. That's all in:

[PATCH 05/12] README: document _begin_fstests better

These fixes address all the known internal fstests problems with the new group list generation code. I still don't know why Darrick had deprecated tests run inappropriately or marked as failed - I can't reproduce anything like what he described and he gave me no details of how to reproduce what he saw.

Cheers,

Dave.