Skip to content

Implement UVC v1.5 ROI

Yunke Cao linux-media oe-kbuild oe-kbuild-all 14 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v14 Latest11 patches 24 repliesIn review
  2. v1311 patches 4 repliesSuperseded
  3. v1211 patches 5 repliesSuperseded
Earlier versions · 11
VersionPostedPatchesRepliesStatus
v1111 patches19 repliesSuperseded
v10 posting 2/211 patches7 repliesSuperseded
v10 posting 1/211 patches15 repliesSuperseded
v911 patches3 repliesSuperseded
v810 patches4 repliesSuperseded
v77 patches24 repliesSuperseded
v55 patches5 repliesSuperseded
v44 patches7 repliesSuperseded
v36 patches9 repliesSuperseded
v26 patches8 repliesSuperseded
v16 patches0 repliesSuperseded

Patches in v14 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECTDocumentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst Documentation/userspace-api/media/videodev2.h.rst.exceptions +3 more+31 -14 replies
2/11media: uvcvideo: add uvc_ctrl_get_boundary for getting default valuedrivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvc_v4l2.c drivers/media/usb/uvc/uvcvideo.h+51 -51 reply
3/11media: uvcvideo: introduce __uvc_ctrl_get_std()drivers/media/usb/uvc/uvc_ctrl.c+28 -141 reply
4/11media: uvcvideo: Split uvc_control_mapping.size to v4l2 and data sizeDocumentation/userspace-api/media/drivers/uvcvideo.rst drivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvc_v4l2.c +1 more+47 -433 replies
5/11media: uvcvideo: Add support for compound controlsdrivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvcvideo.h+164 -195 replies
6/11v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VALDocumentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst Documentation/userspace-api/media/videodev2.h.rst.exceptions +7 more+248 -483 replies
7/11media: vivid: Add an rectangle controldrivers/media/test-drivers/vivid/vivid-ctrls.c+34 -00 replies
8/11media: uvcvideo: support V4L2_CTRL_WHICH_MIN/MAX_VALdrivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvc_v4l2.c drivers/media/usb/uvc/uvcvideo.h+61 -131 reply
9/11media: uvcvideo: implement UVC v1.5 ROIdrivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvc_v4l2.c drivers/media/usb/uvc/uvcvideo.h +3 more+167 -102 replies
10/11media: uvcvideo: initilaize ROI control to default valuedrivers/media/usb/uvc/uvc_ctrl.c drivers/media/usb/uvc/uvcvideo.h+160 -1161 reply
11/11media: uvcvideo: document UVC v1.5 ROIDocumentation/userspace-api/media/drivers/uvcvideo.rst+62 -03 replies

Reviews trailers per patch

8 of 11 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartRicardo RibaldaSergey SenozhatskyDaniel ScallyHans Verkuil
1/11R-b R-b R-b R-b R-b
2/11R-b R-b
3/11
4/11R-b
5/11R-b
6/11
7/11R-b
8/11R-b R-b
9/11R-b
10/11
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v14 thread

Cover letter [PATCH v14 00/11] Implement UVC v1.5 ROI

Hi,

This patch set implements UVC v1.5 region of interest using V4L2 control API.

ROI control is consisted two uvc specific controls.
1. A rectangle control with a newly added type V4L2_CTRL_TYPE_RECT.
2. An auto control with type bitmask.

V4L2_CTRL_WHICH_MIN/MAX_VAL is added to support the rectangle control.

The corresponding v4l-utils series can be found at
https://patchwork.linuxtv.org/project/linux-media/list/?series=11069 .

Tested with v4l2-compliance, v4l2-ctl, calling ioctls on usb cameras and VIVID with a newly added V4L2_CTRL_TYPE_RECT control.

Hans Verkuil (1):
v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL

Yunke Cao (10):
media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECT
media: uvcvideo: add uvc_ctrl_get_boundary for getting default value
media: uvcvideo: introduce __uvc_ctrl_get_std()
media: uvcvideo: Split uvc_control_mapping.size to v4l2 and data size
media: uvcvideo: Add support for compound controls
media: vivid: Add an rectangle control
media: uvcvideo: support V4L2_CTRL_WHICH_MIN/MAX_VAL
media: uvcvideo: implement UVC v1.5 ROI
media: uvcvideo: initilaize ROI control to default value
media: uvcvideo: document UVC v1.5 ROI

 .../userspace-api/media/drivers/uvcvideo.rst  |  64 +-
 .../media/v4l/vidioc-g-ext-ctrls.rst          |  26 +-
 .../media/v4l/vidioc-queryctrl.rst            |  14 +
 .../media/videodev2.h.rst.exceptions          |   4 +
 drivers/media/i2c/imx214.c                    |   5 +-
 .../media/platform/qcom/venus/venc_ctrls.c    |   9 +-
 .../media/test-drivers/vivid/vivid-ctrls.c    |  34 +
 drivers/media/usb/uvc/uvc_ctrl.c              | 721 ++++++++++++++----
 drivers/media/usb/uvc/uvc_v4l2.c              |  18 +-
 drivers/media/usb/uvc/uvcvideo.h              |  24 +-
 drivers/media/v4l2-core/v4l2-ctrls-api.c      |  54 +-
 drivers/media/v4l2-core/v4l2-ctrls-core.c     | 167 +++-
 drivers/media/v4l2-core/v4l2-ioctl.c          |   4 +-
 include/media/v4l2-ctrls.h                    |  38 +-
 include/uapi/linux/usb/video.h                |   1 +
 include/uapi/linux/uvcvideo.h                 |  13 +
 include/uapi/linux/v4l2-controls.h            |   9 +
 include/uapi/linux/videodev2.h                |   5 +
 18 files changed, 997 insertions(+), 213 deletions(-)
Signature · 1 line
2.43.0.rc2.451.g8631bc7472-goog