Skip to content

ASoC: SOF: Introduce generic (in)firmware tracing infrastructure

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8ASoC: SOF: Introduce IPC independent ops for firmware tracing supportsound/soc/sof/sof-priv.h+18 -00 replies
2/8ASoC: SOF: Rename dtrace_is_supported flag to fw_trace_is_supportedsound/soc/sof/core.c sound/soc/sof/intel/hda-dsp.c sound/soc/sof/sof-priv.h +1 more+12 -100 replies
3/8ASoC: SOF: Clone the trace code to ipc3-dtrace as fw_tracing implementationsound/soc/sof/Makefile sound/soc/sof/ipc3-dtrace.c sound/soc/sof/ipc3-priv.h +1 more+612 -00 replies
4/8ASoC: SOF: Switch to IPC generic firmware tracingsound/soc/sof/core.c sound/soc/sof/debug.c sound/soc/sof/ipc.c +5 more+44 -6150 replies
5/8ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to privatesound/soc/sof/ipc3-dtrace.c sound/soc/sof/ipc3-priv.h sound/soc/sof/ops.h+37 -310 replies
6/8ASoC: SOF: Modify the host trace_init parameter list to include dmabsound/soc/sof/amd/acp-trace.c sound/soc/sof/amd/acp.h sound/soc/sof/intel/hda-trace.c +4 more+11 -90 replies
7/8ASoC: SOF: Introduce opaque storage of private data for firmware tracingsound/soc/sof/sof-priv.h+1 -00 replies
8/8ASoC: SOF: ipc3-dtrace: Move dtrace related variables local from sof_devsound/soc/sof/ipc3-dtrace.c sound/soc/sof/sof-priv.h+93 -650 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchRanjani SridharanBard LiaoPierre-Louis BossartPaul Olaru
1/8R-b R-b R-b
2/8R-b R-b R-b
3/8R-b R-b R-b
4/8R-b R-b R-b
5/8R-b R-b R-b R-b
6/8R-b R-b R-b R-b
7/8R-b R-b R-b R-b
8/8R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] ASoC: SOF: Introduce generic (in)firmware tracing infrastructure

Hi,

SOF is using dma-trace (or dtrace) as a firmware tracing method, which is only supported with IPC3 and it is not applicable for IPC4.

Currently the dtrace is 'open managed' regardless of IPC version (we do force disable it for IPC4, but the dtrace calls remain in place).

From the kernel point of view there are only few ops that needs to be exposed by the firmware tracing support and everything else is IPC private, should not be known by the core.

This series converts the current dma-trace as ipc3 specific firmware tracing sub-component and moves all private data out from generic code.

Regards,
Peter
---
Peter Ujfalusi (8):
ASoC: SOF: Introduce IPC independent ops for firmware tracing support
ASoC: SOF: Rename dtrace_is_supported flag to fw_trace_is_supported
ASoC: SOF: Clone the trace code to ipc3-dtrace as fw_tracing
implementation
ASoC: SOF: Switch to IPC generic firmware tracing
ASoC: SOF: ipc3-dtrace: Move host ops wrappers from generic header to
private
ASoC: SOF: Modify the host trace_init parameter list to include dmab
ASoC: SOF: Introduce opaque storage of private data for firmware
tracing
ASoC: SOF: ipc3-dtrace: Move dtrace related variables local from
sof_dev

 sound/soc/sof/Makefile          |   1 +
 sound/soc/sof/amd/acp-trace.c   |   4 +-
 sound/soc/sof/amd/acp.h         |   2 +-
 sound/soc/sof/core.c            |  13 +-
 sound/soc/sof/debug.c           |   2 +-
 sound/soc/sof/intel/hda-dsp.c   |   2 +-
 sound/soc/sof/intel/hda-trace.c |   4 +-
 sound/soc/sof/intel/hda.h       |   2 +-
 sound/soc/sof/ipc.c             |   6 +
 sound/soc/sof/ipc3-dtrace.c     | 649 ++++++++++++++++++++++++++++++++
 sound/soc/sof/ipc3-priv.h       |  38 ++
 sound/soc/sof/ipc3.c            |   3 +-
 sound/soc/sof/ops.c             |   2 +-
 sound/soc/sof/ops.h             |  26 --
 sound/soc/sof/pm.c              |   8 +-
 sound/soc/sof/sof-priv.h        |  53 +--
 sound/soc/sof/trace.c           | 621 ++----------------------------
 17 files changed, 767 insertions(+), 669 deletions(-)
 create mode 100644 sound/soc/sof/ipc3-dtrace.c
Signature · 1 line
2.36.1