Skip to content

Add support for XP-PEN Deco L

José Expósito linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 1 replyIn review
  2. v34 patches 2 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Group all the test of the subsystem under HID_KUNIT_TEST:
HID_UCLOGIC_KUNIT_TEST -> HID_KUNIT_TEST
- Remove DISABLE_STRUCTLEAK_PLUGIN:
https://lore.kernel.org/dri-devel/CAGS_qxpFO4ixW=08ZcdcD9J1kU=B3mwoBJkPW8AKu0sKs8aKfA@mail.gmail.com/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4HID: uclogic: Make template placeholder IDs genericdrivers/hid/hid-uclogic-params.c drivers/hid/hid-uclogic-rdesc.c drivers/hid/hid-uclogic-rdesc.h+14 -140 replies
2/4HID: uclogic: Add KUnit tests for uclogic_rdesc_template_apply()drivers/hid/.kunitconfig drivers/hid/Kconfig drivers/hid/Makefile +1 more+207 -00 replies
3/4HID: uclogic: Allow to generate frame templatesdrivers/hid/hid-uclogic-rdesc-test.c drivers/hid/hid-uclogic-rdesc.c drivers/hid/hid-uclogic-rdesc.h+53 -30 replies
4/4HID: uclogic: Add support for XP-PEN Deco Ldrivers/hid/hid-ids.h drivers/hid/hid-uclogic-core.c drivers/hid/hid-uclogic-params.c +2 more+310 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] Add support for XP-PEN Deco L

Hello everyone,

This patchset adds support for the UGEE XP-PEN Deco L tablet. This device belongs to a family of tablets that must receive a chunk of magic data in order to be enabled (named UGEE v2 internally).

Once the device is enabled, its parameters can be discovered by parsing a report descriptor. HUION v1 tablets have a similar report descriptor but, in the case of UGEE v2 tablets, the number of buttons are also discoverable [1].

The ability to discover the number of buttons is the reason for the first 3 patches. They enable frame templates.
Because I lack the hardware to fully test this driver, I added some KUnit tests to make sure no bugs are introduced.
I didn't see any other test in the subsystem (and I doubt I'm the first person writing one) so please let me know if I need to move the test to a different place.

The last patch enables the tablet.

Best wishes,
José Expósito

[1] I don't own a HUION v1 device, so I'm not sure if the information about the number of buttons is also present and it is not used in the driver for some reason.
[2] https://lore.kernel.org/linux-input/20220516112159.GA74406@elementary/T/#t

---

v1 - https://lore.kernel.org/linux-input/[email protected]/

v2 - https://lore.kernel.org/linux-input/[email protected]/T/

- Add MODULE_DESCRIPTION/LICENSE/AUTHOR to hid-uclogic-rdesc-test.c
- Remove unused variable in uclogic_params_ugee_v2_init
- Add sparse __force anotation in the result of cpu_to_le16
- Add DISABLE_STRUCTLEAK_PLUGIN for KUnit tests

v3 - https://lore.kernel.org/linux-input/[email protected]/T/

- Improve Kconfig message
- Add .kunitconfig. Thanks to Daniel Latypov for suggesting it in an unrelated patch:
https://lore.kernel.org/dri-devel/CAGS_qxpV2SsihEdgXZ6+7N0dxLmdRANq+qE4iUZ2aNrf6vuLYg@mail.gmail.com/

v4:

- Group all the test of the subsystem under HID_KUNIT_TEST:
HID_UCLOGIC_KUNIT_TEST -> HID_KUNIT_TEST
- Remove DISABLE_STRUCTLEAK_PLUGIN:
https://lore.kernel.org/dri-devel/CAGS_qxpFO4ixW=08ZcdcD9J1kU=B3mwoBJkPW8AKu0sKs8aKfA@mail.gmail.com/

José Expósito (4):
HID: uclogic: Make template placeholder IDs generic
HID: uclogic: Add KUnit tests for uclogic_rdesc_template_apply()
HID: uclogic: Allow to generate frame templates
HID: uclogic: Add support for XP-PEN Deco L

 drivers/hid/.kunitconfig             |   5 +
 drivers/hid/Kconfig                  |  16 ++
 drivers/hid/Makefile                 |   3 +
 drivers/hid/hid-ids.h                |   1 +
 drivers/hid/hid-uclogic-core.c       |   2 +
 drivers/hid/hid-uclogic-params.c     | 201 +++++++++++++++++++++++-
 drivers/hid/hid-uclogic-rdesc-test.c | 219 +++++++++++++++++++++++++++
 drivers/hid/hid-uclogic-rdesc.c      | 124 ++++++++++++++-
 drivers/hid/hid-uclogic-rdesc.h      |  24 ++-
 9 files changed, 581 insertions(+), 14 deletions(-)
 create mode 100644 drivers/hid/.kunitconfig
 create mode 100644 drivers/hid/hid-uclogic-rdesc-test.c
Signature · 1 line
2.25.1