Skip to content

net: dsa: microchip: refactor the ksz switch init function

Arun Ramadoss lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 3 repliesApplied 9/9

Changes in v1 from the cover letter

- Added the macros for the chip id
- Updated the ksz8863_smi of_device_id data
- Moved the patch 4 port allocation after the patch on mib_names to ksz_common

Patches in v1 All 9 applied

#Subject and filesSizeRepliesApplied
1/9net: dsa: microchip: ksz8795: update the port_cnt value in ksz_chip_datadrivers/net/dsa/microchip/ksz8795.c+3 -20 repliesApplied
2/9net: dsa: microchip: move ksz_chip_data to ksz_commondrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c +1 more+259 -2060 repliesApplied
3/9net: dsa: microchip: perform the compatibility check for dev probeddrivers/net/dsa/microchip/ksz8795_spi.c drivers/net/dsa/microchip/ksz8863_smi.c drivers/net/dsa/microchip/ksz9477_i2c.c +3 more+109 -221 replyApplied
4/9net: dsa: microchip: move struct mib_names to ksz_chip_datadrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c +1 more+149 -1571 replyApplied
5/9net: dsa: microchip: move port memory allocation to ksz_commondrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c+21 -421 replyApplied
6/9net: dsa: microchip: move get_strings to ksz_commondrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c +1 more+20 -290 repliesApplied
7/9net: dsa: move mib->cnt_ptr reset code to ksz_common.cdrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c+7 -60 repliesApplied
8/9net: dsa: microchip: add the phylink get_capsdrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz9477.c drivers/net/dsa/microchip/ksz_common.c +1 more+117 -90 repliesApplied
9/9net: dsa: microchip: remove unused members in ksz_devicedrivers/net/dsa/microchip/ksz8795.c drivers/net/dsa/microchip/ksz_common.h+1 -60 repliesApplied

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliVladimir Oltean
1/9R-b R-b
2/9R-b R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b R-b
7/9R-b R-b
8/9R-b R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Patch net-next 0/9] net: dsa: microchip: refactor the ksz switch init function

During the ksz_switch_register function, it calls the individual switches init functions (ksz8795.c and ksz9477.c). Both these functions have few things in common like, copying the chip specific data to struct ksz_dev, allocating ksz_port memory and mib_names memory & cnt. And to add the new LAN937x series switch, these allocations has to be replicated.
Based on the review feedback of LAN937x part support patch, refactored the switch init function to move allocations to switch register.

Changes in Patch v1
- Added the macros for the chip id
- Updated the ksz8863_smi of_device_id data
- Moved the patch 4 port allocation after the patch on mib_names to ksz_common

Changes in RFC v2
- Fixed the compilation issue

Arun Ramadoss (8):
net: dsa: microchip: ksz8795: update the port_cnt value in
ksz_chip_data
net: dsa: microchip: move ksz_chip_data to ksz_common
net: dsa: microchip: perform the compatibility check for dev probed
net: dsa: microchip: move struct mib_names to ksz_chip_data
net: dsa: microchip: move port memory allocation to ksz_common
net: dsa: microchip: move get_strings to ksz_common
net: dsa: microchip: add the phylink get_caps
net: dsa: microchip: remove unused members in ksz_device

Prasanna Vengateshan (1):
net: dsa: move mib->cnt_ptr reset code to ksz_common.c

 drivers/net/dsa/microchip/ksz8795.c     | 252 +-----------
 drivers/net/dsa/microchip/ksz8795_spi.c |  35 +-
 drivers/net/dsa/microchip/ksz8863_smi.c |  10 +-
 drivers/net/dsa/microchip/ksz9477.c     | 200 ++--------
 drivers/net/dsa/microchip/ksz9477_i2c.c |  30 +-
 drivers/net/dsa/microchip/ksz9477_spi.c |  30 +-
 drivers/net/dsa/microchip/ksz_common.c  | 485 +++++++++++++++++++++++-
 drivers/net/dsa/microchip/ksz_common.h  |  79 +++-
 8 files changed, 664 insertions(+), 457 deletions(-)

base-commit: 6251264fedde83ade6f0f1f7049037469dd4de0b

Signature · 1 line
2.33.0