Skip to content

tty/serial: Termios flag fixes

Ilpo Järvinen linux-arm-kernel linux-riscv linux-serial lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 1 replyIn review
  2. v19 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Corrected shortlog typo

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9serial: uartlite: Fix BRKINT clearingdrivers/tty/serial/uartlite.c+2 -10 replies
2/9serial: digicolor-usart: Don't allow CS5-6drivers/tty/serial/digicolor-usart.c+2 -00 replies
3/9serial: rda-uart: Don't allow CS5-6drivers/tty/serial/rda-uart.c+2 -00 replies
4/9serial: txx9: Don't allow CS5-6drivers/tty/serial/serial_txx9.c+2 -00 replies
5/9serial: sh-sci: Don't allow CS5-6drivers/tty/serial/sh-sci.c+5 -10 replies
6/9serial: sifive: Sanitize CSIZE and c_iflagdrivers/tty/serial/sifive.c+5 -10 replies
7/9serial: st-asc: Sanitize CSIZE and correct PARENB for CS7drivers/tty/serial/st-asc.c+4 -01 reply
8/9serial: stm32-usart: Correct CSIZE, bits, and paritydrivers/tty/serial/stm32-usart.c+12 -30 replies
9/9pcmcia: synclink_cs: Don't allow CS5-6drivers/char/pcmcia/synclink_cs.c+5 -10 replies

Reviews trailers per patch

3 of 9 patches have a Reviewed-by or Acked-by.

PatchSean AndersonBaruch SiachPatrice Chotard
1/9R-b
2/9A-b
3/9
4/9
5/9
6/9
7/9R-b
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] tty/serial: Termios flag fixes

Here are a few termios flag fixes, mostly CSIZE but a few other flags as well. The fixed flags returned to userspace should now match to what the driver is using. Incorrect CSIZE also causes a miscalculation of timeout in serial core (but it might not be a huge problem being just a handwavy long timeout).

v2:
- Corrected shortlog typo

Ilpo Järvinen (9):
serial: uartlite: Fix BRKINT clearing
serial: digicolor-usart: Don't allow CS5-6
serial: rda-uart: Don't allow CS5-6
serial: txx9: Don't allow CS5-6
serial: sh-sci: Don't allow CS5-6
serial: sifive: Sanitize CSIZE and c_iflag
serial: st-asc: Sanitize CSIZE and correct PARENB for CS7
serial: stm32-usart: Correct CSIZE, bits, and parity
pcmcia: synclink_cs: Don't allow CS5-6

 drivers/char/pcmcia/synclink_cs.c    |  6 +++++-
 drivers/tty/serial/digicolor-usart.c |  2 ++
 drivers/tty/serial/rda-uart.c        |  2 ++
 drivers/tty/serial/serial_txx9.c     |  2 ++
 drivers/tty/serial/sh-sci.c          |  6 +++++-
 drivers/tty/serial/sifive.c          |  6 +++++-
 drivers/tty/serial/st-asc.c          |  4 ++++
 drivers/tty/serial/stm32-usart.c     | 15 ++++++++++++---
 drivers/tty/serial/uartlite.c        |  3 ++-
 9 files changed, 39 insertions(+), 7 deletions(-)
Signature · 1 line
2.30.2