Skip to content

ceph: convert to netfs_direct_read_iter for DIO reads

Jeff Layton ceph-devel linux-fsdevel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4netfs: fix sense of DIO test on short readfs/netfs/io.c+1 -10 replies
2/4ceph: Use the provided iterator in ceph_netfs_issue_op()fs/ceph/addr.c+4 -80 replies
3/4ceph: enhance dout messages in issue_read codepathsfs/ceph/addr.c+5 -10 replies
4/4ceph: switch to netfs_direct_read_iterfs/ceph/addr.c fs/ceph/file.c+30 -140 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchXiubo Li
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] ceph: convert to netfs_direct_read_iter for DIO reads

This patch series is based on top of David Howells' netfs-lib branch.

I previously sent an RFC set for this back in early April, but David has revised his netfs-lib branch since then. This converts ceph to use the new DIO read helper netfs_direct_read_iter instead of using our own routine.

With this change we ought to be able to rip out a large swath of ceph_direct_read_write, but I've decided to wait on that until the write helpers are in place and we can just remove that function wholesale.

David, do you mind carrying these patches in your tree? Given that they depend on your netfs-lib branch, it's probably simpler to do it that way rather than have us base the ceph-client master branch on yours. If conflicts crop up, we can revisit that approach though.

David Howells (1):
ceph: Use the provided iterator in ceph_netfs_issue_op()

Jeff Layton (3):
netfs: fix sense of DIO test on short read
ceph: enhance dout messages in issue_read codepaths
ceph: switch to netfs_direct_read_iter

 fs/ceph/addr.c | 55 +++++++++++++++++++++++++++++++++-----------------
 fs/ceph/file.c |  3 +--
 fs/netfs/io.c  |  2 +-
 3 files changed, 38 insertions(+), 22 deletions(-)
Signature · 1 line
2.36.1