Skip to content

memcontrol selftests fixups

Michal Koutný cgroups linux-kselftest linux-mm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 2 repliesIn review
  2. v25 patches 4 repliesApplied 5/5
  3. v14 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5selftests: memcg: Fix compilationtools/testing/selftests/cgroup/test_memcontrol.c+14 -110 replies
2/5selftests: memcg: Expect no low events in unprotected siblingtools/testing/selftests/cgroup/test_memcontrol.c+1 -11 reply
3/5selftests: memcg: Adjust expected reclaim values of protected cgroupsMAINTAINERS tools/testing/selftests/cgroup/memcg_protection.m tools/testing/selftests/cgroup/test_memcontrol.c+107 -120 replies
4/5selftests: memcg: Remove protection from top level memcgtools/testing/selftests/cgroup/test_memcontrol.c+3 -70 replies
5/5selftests: memcg: Factor out common parts of memory.{low,min} teststools/testing/selftests/cgroup/test_memcontrol.c+36 -1631 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDavid VernetRoman Gushchin
1/5R-b A-b
2/5R-b A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] memcontrol selftests fixups

Hello.

I'm just flushing the patches to make memcontrol selftests check the events behavior we had consensus about (test_memcg_low fails).

(test_memcg_reclaim, test_memcg_swap_max fail for me now but it's present even before the refactoring.)

The two bigger changes are:
- adjustment of the protected values to make tests succeed with the given tolerance,
- both test_memcg_low and test_memcg_min check protection of memory in populated cgroups (actually as per Documentation/admin-guide/cgroup-v2.rst memory.min should not apply to empty cgroups, which is not the case currently. Therefore I unified tests with the populated case in order to to bring more broken tests).

Thanks,
Michal

Changes from v2 (https://lore.kernel.org/r/20220518161859.21565-2-mkoutny-IBi9RG/[email protected]/)
- rebased on mm-stable 02e34fff195d3a5f67cbb553795dc109a37d1dcf
- collected acked-bys
- proper Fixes: tag

Changes from v1 (https://lore.kernel.org/r/20220513171811.730-1-mkoutny-IBi9RG/[email protected]/)
- fixed mis-rebase in compilation fix patch,
- added review, ack tags from v1,
- applied feedback from v1 (Octave script in git tree),
- added one more patch extracting common parts,
- rebased on mm-stable bbe832b9db2e.

Michal Koutný (5):
selftests: memcg: Fix compilation
selftests: memcg: Expect no low events in unprotected sibling
selftests: memcg: Adjust expected reclaim values of protected cgroups
selftests: memcg: Remove protection from top level memcg
selftests: memcg: Factor out common parts of memory.{low,min} tests

 MAINTAINERS                                   |   1 +
 .../selftests/cgroup/memcg_protection.m       |  89 +++++++
 .../selftests/cgroup/test_memcontrol.c        | 247 +++++-------------
 3 files changed, 152 insertions(+), 185 deletions(-)
 create mode 100644 tools/testing/selftests/cgroup/memcg_protection.m
Signature · 1 line
2.35.3