Skip to content

Add Machine driver support for nau8825, max98560 and rt5682s, rt1019

V sujith kumar Reddy alsa-devel lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 2 repliesIn review
  2. v42 patches 5 repliesSuperseded
  3. v32 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches2 repliesSuperseded
v12 patches0 repliesSuperseded

Changes in v5 from the cover letter

Resolved:
. Used separate firmware files.
. Deleted useless initialization variables

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: amd: acp: Add support for nau8825 and max98360 cardsound/soc/amd/acp-config.c sound/soc/amd/acp/Kconfig sound/soc/amd/acp/acp-mach-common.c +3 more+201 -61 reply
2/2ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs instancesound/soc/amd/acp-config.c sound/soc/amd/acp/acp-mach-common.c sound/soc/amd/acp/acp-sof-mach.c+81 -100 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAkihiko Odaki
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2]Add Machine driver support for nau8825, max98560 and rt5682s, rt1019

This patch set depends on:

        --gpio patch
        --https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/
        --https://patchwork.kernel.org/project/alsa-devel/patch/[email protected]/

v4 --> v5:
Resolved:
. Used separate firmware files.
. Deleted useless initialization variables

v3 --> v4:
Resolved:
. Assigning direct address without (void *) typecast.
. Used snd_soc_card_jack_new instead of snd_soc_card_jack_new_pins as per suggestion.

v2 --> v3:
Resolved compilation error:

/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c: In function ‘acp_card_nau8825_init’:
/build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:479:15: error: too many arguments to function ‘snd_soc_card_jack_new’
479 | ret = snd_soc_card_jack_new(card, "Headset Jack",

      |               ^~~~~~~~~~~~~~~~~~~~~

In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/amd/acp/acp-mach-common.c:20:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id,

V sujith kumar Reddy (2):
ASoC: amd: acp: Add support for nau8825 and max98360 card
ASoC: amd: acp: Add support for rt5682s and rt1019 card with hs
instance

 sound/soc/amd/acp-config.c          |  30 ++++
 sound/soc/amd/acp/Kconfig           |   1 +
 sound/soc/amd/acp/acp-mach-common.c | 233 ++++++++++++++++++++++++++--
 sound/soc/amd/acp/acp-mach.h        |   3 +
 sound/soc/amd/acp/acp-sof-mach.c    |  30 ++++
 sound/soc/amd/mach-config.h         |   1 +
 6 files changed, 282 insertions(+), 16 deletions(-)
Signature · 1 line
2.25.1