perf_counts clean up and perf stat report bug fix
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | perf stat: Fix and validate inputs in stat eventstools/ | +14 | 0 replies | |
| 2/5 | perf stat: Add stat record+report testtools/ | +13 | 0 replies | |
| 3/5 | perf cpumap: Add perf_cpu_map__for_each_idxtools/ | +3 | 0 replies | |
| 4/5 | perf bpf_counter: Tidy use of CPU map indextools/ | +35 | 0 replies | |
| 5/5 | perf stat: Make use of index clearer with perf_countstools/ tools/ | +16 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] perf_counts clean up and perf stat report bug fix
perf_counts takes a CPU map index as an argument, however, there were a few places where this hadn't been cleaned up and the index was called cpu. In part this led to the bug discovered by Michael Petlan in:
https://lore.kernel.org/linux-perf-users/CAP-5=fWQR=sCuiSMktvUtcbOLidEpUJLCybVF6=BRvORcDOq+g@mail.gmail.com/
Fix the bug, tidy up more of the arguments passed to perf_counts, add a test to ensure the bug isn't reintroduced and add a helper macro to iterate over just CPU map indices.
Ian Rogers (5):
perf stat: Fix and validate inputs in stat events perf stat: Add stat record+report test
perf cpumap: Add perf_cpu_map__for_each_idx perf bpf_counter: Tidy use of CPU map index perf stat: Make use of index clearer with perf_counts
tools/lib/perf/include/perf/cpumap.h | 3 ++ tools/perf/tests/shell/stat.sh | 13 ++++++ tools/perf/util/bpf_counter.c | 61 ++++++++++++++++------------ tools/perf/util/stat-display.c | 22 +++++----- tools/perf/util/stat.c | 27 ++++++++---- 5 files changed, 81 insertions(+), 45 deletions(-)
Signature · 1 line
2.36.1.124.g0e6072fb45-goog