fat: add support for the renameat2 RENAME_EXCHANGE flag
Status from this message: [merged mm-nonmm-stable] selftests-filesystems-add-a-vfat-rename_exchange-test.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest4 patches 1 replyApplied 4/4
- v54 patches 4 repliesSuperseded
- v44 patches 7 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 3 patches | 5 replies | Superseded | |
| v2 | 3 patches | 2 replies | Superseded | |
| v1 RFC | 3 patches | 6 replies | Superseded |
Changes in v6 from the cover letter
- Simplify logic to determine if nlink have to modified (OGAWA Hirofumi).
Patches in v6 All 4 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | fat: add a vfat_rename2() and make existing .rename callback a helperfs/ | +14 | 0 replies | Applied |
| 2/4 | fat: factor out reusable code in vfat_rename() as helper functionsfs/ | +57 | 0 replies | Applied |
| 3/4 | fat: add renameat2 RENAME_EXCHANGE flag supportfs/ | +122 | 0 replies | Applied |
| 4/4 | selftests/filesystems: add a vfat RENAME_EXCHANGE testMAINTAINERS tools/ tools/ +4 more | +132 | 0 replies | Applied |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Muhammad Usama Anjum | OGAWA Hirofumi |
|---|---|---|
| Series | A-b | |
| 1/4 | ||
| 2/4 | ||
| 3/4 | ||
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/4] fat: add support for the renameat2 RENAME_EXCHANGE flag
Hello,
The series adds support for the renameat2 system call RENAME_EXCHANGE flag (which allows to atomically replace two paths) to the vfat filesystem code.
There are many use cases for this, but we are particularly interested in making possible for vfat filesystems to be part of OSTree [0] deployments.
Currently OSTree relies on symbolic links to make the deployment updates an atomic transactional operation. But RENAME_EXCHANGE could be used [1] to achieve a similar level of robustness when using a vfat filesystem.
Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE support, patch #2 moves some code blocks in vfat_rename() to a set of helper functions, that can be reused by tvfat_rename_exchange() that's added by patch #3 and finally patch #4 adds some kselftests to test it.
This is a v6 that addresses issues pointed out in v5:
https://lkml.org/lkml/2022/6/9/361
[0]: https://github.com/ostreedev/ostree
[1]: https://github.com/ostreedev/ostree/issues/1649
Changes in v6:
- Simplify logic to determine if nlink have to modified (OGAWA Hirofumi).
Changes in v5:
- Only update nlink for different parent dirs and file types (OGAWA Hirofumi).
Changes in v4:
- Add new patch from OGAWA Hirofumi to use the helpers in vfat_rename().
- Rebase the patch on top of OGAWA Hirofumi proposed changes.
- Drop iversion increment for old and new file inodes (OGAWA Hirofumi).
- Add Muhammad Usama Anjum Acked-by tag.
Changes in v3:
- Add a .gitignore for the rename_exchange binary (Muhammad Usama Anjum).
- Include $(KHDR_INCLUDES) instead of hardcoding a relative path in Makefile (Muhammad Usama Anjum).
Changes in v2:
- Only update the new_dir inode version and timestamps if != old_dir (Alex Larsson).
- Add some helper functions to avoid duplicating code (OGAWA Hirofumi).
- Use braces for multi-lines blocks even if are one statement (OGAWA Hirofumi).
- Mention in commit message that the operation is as transactional as possible but within the vfat limitations of not having a journal (Colin Walters).
- Call sync to flush the page cache before checking the file contents (Alex Larsson).
- Drop RFC prefix since the patches already got some review.
Javier Martinez Canillas (3):
fat: add a vfat_rename2() and make existing .rename callback a helper
fat: add renameat2 RENAME_EXCHANGE flag support selftests/filesystems: add a vfat RENAME_EXCHANGE test
OGAWA Hirofumi (1):
fat: factor out reusable code in vfat_rename() as helper functions
MAINTAINERS | 1 + fs/fat/namei_vfat.c | 231 +++++++++++++++--- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fat/.gitignore | 2 + .../selftests/filesystems/fat/Makefile | 7 + .../testing/selftests/filesystems/fat/config | 2 + .../filesystems/fat/rename_exchange.c | 37 +++ .../filesystems/fat/run_fat_tests.sh | 82 +++++++ 8 files changed, 324 insertions(+), 39 deletions(-) create mode 100644 tools/testing/selftests/filesystems/fat/.gitignore create mode 100644 tools/testing/selftests/filesystems/fat/Makefile create mode 100644 tools/testing/selftests/filesystems/fat/config create mode 100644 tools/testing/selftests/filesystems/fat/rename_exchange.c create mode 100755 tools/testing/selftests/filesystems/fat/run_fat_tests.sh
Signature · 1 line
2.36.1