Skip to content

bfq: Improve waker detection

Jan Kara linux-block 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4bfq: Relax waker detection for shared queuesblock/bfq-iosched.c block/bfq-iosched.h+4 -20 replies
2/4bfq: Allow current waker to defend against a tentative oneblock/bfq-iosched.c+1 -20 replies
3/4bfq: Remove superfluous conversion from RQ_BIC()block/bfq-iosched.c+1 -10 replies
4/4bfq: Remove bfq_requeue_request_body()block/bfq-iosched.c+2 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] bfq: Improve waker detection

Hello,

this patch series restores regression in dbench for large number of processes that was introduced by c65e6fd460b4 ("bfq: Do not let waker requests skip proper accounting"). The detailed explanation is in the first patch but the culprit in the end was that with large number of dbench clients it often happened that flush worker bfqq replaced jbd2 bfqq as a waker of the bfqq shared by dbench clients and that resulted in lot of idling and reduced throughput.

The first two patches in this series improve the waker detection, the other two are just cleanups I've spotted when working on the code.

I've tested the patches and they don't seem to cause regression for other workloads.

Honza