Skip to content

Specify clock provider directly to CPU DAIs

Charles Keepax alsa-devel linux-amlogic linux-mediatek linux-mips linux-omap linux-rockchip linux-sunxi linux-tegra 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest56 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/56ASoC: core: Add set_fmt_new callback that directly specifies providerinclude/sound/soc-dai.h sound/soc/soc-core.c sound/soc/soc-dai.c+13 -20 replies
2/56ASoC: amd: vangogh: Update to use set_fmt_new callbacksound/soc/amd/vangogh/acp5x-i2s.c+3 -30 replies
3/56ASoC: atmel: Update to use set_fmt_new callbacksound/soc/atmel/atmel-i2s.c sound/soc/atmel/atmel_ssc_dai.c sound/soc/atmel/mchp-i2s-mcc.c +1 more+21 -210 replies
4/56ASoC: au1x: Update to use set_fmt_new callbacksound/soc/au1x/i2sc.c sound/soc/au1x/psc-i2s.c+5 -50 replies
5/56ASoC: bcm: Update to use set_fmt_new callbacksound/soc/bcm/bcm2835-i2s.c sound/soc/bcm/cygnus-ssp.c+14 -140 replies
6/56ASoC: ep93xx: Update to use set_fmt_new callbacksound/soc/cirrus/ep93xx-i2s.c+3 -30 replies
7/56ASoC: dwc: Update to use set_fmt_new callbacksound/soc/dwc/dwc-i2s.c+5 -50 replies
8/56ASoC: fsl: Update to use set_fmt_new callbacksound/soc/fsl/fsl_audmix.c sound/soc/fsl/fsl_esai.c sound/soc/fsl/fsl_mqs.c +4 more+30 -300 replies
9/56ASoC: hisilicon: Update to use set_fmt_new callbacksound/soc/hisilicon/hi6210-i2s.c+10 -100 replies
10/56ASoC: img: Update to use set_fmt_new callbacksound/soc/img/img-i2s-in.c sound/soc/img/img-i2s-out.c+7 -70 replies
11/56ASoC: Intel: Update to use set_fmt_new callbacksound/soc/intel/atom/sst-atom-controls.c sound/soc/intel/atom/sst-mfld-platform-pcm.c sound/soc/intel/boards/bytcht_cx2072x.c +10 more+18 -190 replies
12/56ASoC: js4740-i2s: Update to use set_fmt_new callbacksound/soc/jz4740/jz4740-i2s.c+6 -60 replies
13/56ASoC: mediatek: Update to use set_fmt_new callbacksound/soc/mediatek/mt8195/mt8195-dai-etdm.c sound/soc/mediatek/mt8195/mt8195-dai-pcm.c+9 -90 replies
14/56ASoC: meson: Update to use set_fmt_new callbacksound/soc/meson/aiu-encoder-i2s.c sound/soc/meson/axg-tdm-interface.c+10 -100 replies
15/56ASoC: mxs-saif: Update to use set_fmt_new callbacksound/soc/mxs/mxs-saif.c+3 -30 replies
16/56ASoC: pxa: Update to use set_fmt_new callbacksound/soc/pxa/magician.c sound/soc/pxa/mmp-sspa.c sound/soc/pxa/pxa-ssp.c +1 more+24 -240 replies
17/56ASoC: qcom: Update to use set_fmt_new callbacksound/soc/qcom/apq8016_sbc.c sound/soc/qcom/qdsp6/audioreach.c sound/soc/qcom/qdsp6/q6afe-dai.c +5 more+14 -140 replies
18/56ASoC: rockchip: Update to use set_fmt_new callbacksound/soc/rockchip/rockchip_i2s.c sound/soc/rockchip/rockchip_i2s_tdm.c+8 -81 reply
19/56ASoC: samsung: Update to use set_fmt_new callbacksound/soc/samsung/i2s.c sound/soc/samsung/pcm.c sound/soc/samsung/s3c-i2s-v2.c +1 more+15 -150 replies
20/56ASoC: sh: Update to use set_fmt_new callbacksound/soc/sh/fsi.c sound/soc/sh/rcar/core.c sound/soc/sh/rz-ssi.c +1 more+15 -151 reply
21/56ASoC: stm: Update to use set_fmt_new callbacksound/soc/stm/stm32_i2s.c sound/soc/stm/stm32_sai_sub.c+10 -100 replies
22/56ASoC: sunxi: Update to use set_fmt_new callbacksound/soc/sunxi/sun4i-i2s.c sound/soc/sunxi/sun8i-codec.c+14 -142 replies
23/56ASoC: tegra: Update to use set_fmt_new callbacksound/soc/tegra/tegra20_i2s.c sound/soc/tegra/tegra210_i2s.c sound/soc/tegra/tegra30_i2s.c+12 -120 replies
24/56ASoC: test-component: Update to use set_fmt_new callbacksound/soc/generic/test-component.c+11 -111 reply
25/56ASoC: ti: Update to use set_fmt_new callbacksound/soc/ti/davinci-i2s.c sound/soc/ti/davinci-mcasp.c sound/soc/ti/omap-mcbsp.c+30 -301 reply
26/56ASoC: ux500: Update to use set_fmt_new callbacksound/soc/ux500/ux500_msp_dai.c+19 -190 replies
27/56ASoC: xtensa: Update to use set_fmt_new callbacksound/soc/xtensa/xtfpga-i2s.c+2 -20 replies
28/56ASoC: core: Always send the CPU DAI a direct clock specifiersound/soc/soc-core.c+3 -120 replies
29/56ASoC: amd: vangogh: Rename set_fmt_new back to set_fmtsound/soc/amd/vangogh/acp5x-i2s.c+1 -10 replies
30/56ASoC: atmel: Rename set_fmt_new back to set_fmtsound/soc/atmel/atmel-i2s.c sound/soc/atmel/atmel_ssc_dai.c sound/soc/atmel/mchp-i2s-mcc.c +1 more+4 -40 replies
31/56ASoC: au1x: Rename set_fmt_new back to set_fmtsound/soc/au1x/i2sc.c sound/soc/au1x/psc-i2s.c+2 -20 replies
32/56ASoC: bcm: Rename set_fmt_new back to set_fmtsound/soc/bcm/bcm2835-i2s.c sound/soc/bcm/cygnus-ssp.c+2 -20 replies
33/56ASoC: ep93xx: Rename set_fmt_new back to set_fmtsound/soc/cirrus/ep93xx-i2s.c+1 -10 replies
34/56ASoC: dwc: Rename set_fmt_new back to set_fmtsound/soc/dwc/dwc-i2s.c+1 -10 replies
35/56ASoC: fsl: Rename set_fmt_new back to set_fmtsound/soc/fsl/fsl_audmix.c sound/soc/fsl/fsl_esai.c sound/soc/fsl/fsl_mqs.c +2 more+5 -50 replies
36/56ASoC: hisilicon: Rename set_fmt_new back to set_fmtsound/soc/hisilicon/hi6210-i2s.c+1 -10 replies
37/56ASoC: img: Rename set_fmt_new back to set_fmtsound/soc/img/img-i2s-in.c sound/soc/img/img-i2s-out.c+2 -20 replies
38/56ASoC: Intel: Rename set_fmt_new back to set_fmtsound/soc/intel/atom/sst-mfld-platform-pcm.c sound/soc/intel/keembay/kmb_platform.c+2 -20 replies
39/56ASoC: jz4740-i2s: Rename set_fmt_new back to set_fmtsound/soc/jz4740/jz4740-i2s.c+1 -10 replies
40/56ASoC: mediatek: Rename set_fmt_new back to set_fmtsound/soc/mediatek/mt8195/mt8195-dai-etdm.c sound/soc/mediatek/mt8195/mt8195-dai-pcm.c+3 -30 replies
41/56ASoC: meson: Rename set_fmt_new back to set_fmtsound/soc/meson/aiu-encoder-i2s.c sound/soc/meson/axg-tdm-interface.c+2 -20 replies
42/56ASoC: mxs-saif: Rename set_fmt_new back to set_fmtsound/soc/mxs/mxs-saif.c+1 -10 replies
43/56ASoC: pxa: Rename set_fmt_new back to set_fmtsound/soc/pxa/mmp-sspa.c sound/soc/pxa/pxa-ssp.c sound/soc/pxa/pxa2xx-i2s.c+3 -30 replies
44/56ASoC: qcom: Rename set_fmt_new back to set_fmtsound/soc/qcom/qdsp6/q6afe-dai.c sound/soc/qcom/qdsp6/q6apm-lpass-dais.c+2 -20 replies
45/56ASoC: rockchip: Rename set_fmt_new back to set_fmtsound/soc/rockchip/rockchip_i2s.c sound/soc/rockchip/rockchip_i2s_tdm.c+2 -20 replies
46/56ASoC: samsung: Rename set_fmt_new back to set_fmtsound/soc/samsung/i2s.c sound/soc/samsung/pcm.c sound/soc/samsung/s3c-i2s-v2.c +1 more+4 -41 reply
47/56ASoC: sh: Rename set_fmt_new back to set_fmtsound/soc/sh/fsi.c sound/soc/sh/rcar/core.c sound/soc/sh/rz-ssi.c +1 more+4 -40 replies
48/56ASoC: stm: Rename set_fmt_new back to set_fmtsound/soc/stm/stm32_i2s.c sound/soc/stm/stm32_sai_sub.c+2 -20 replies
49/56ASoC: sunxi: Rename set_fmt_new back to set_fmtsound/soc/sunxi/sun4i-i2s.c sound/soc/sunxi/sun8i-codec.c+2 -20 replies
50/56ASoC: tegra: Rename set_fmt_new back to set_fmtsound/soc/tegra/tegra20_i2s.c sound/soc/tegra/tegra210_i2s.c sound/soc/tegra/tegra30_i2s.c+3 -30 replies
51/56ASoC: test-component: Rename set_fmt_new back to set_fmtsound/soc/generic/test-component.c+2 -20 replies
52/56ASoC: ti: Rename set_fmt_new back to set_fmtsound/soc/ti/davinci-i2s.c sound/soc/ti/davinci-mcasp.c sound/soc/ti/omap-mcbsp.c+3 -31 reply
53/56ASoC: ux500: Rename set_fmt_new back to set_fmtsound/soc/ux500/ux500_msp_dai.c+1 -10 replies
54/56ASoC: xtensa: Rename set_fmt_new back to set_fmtsound/soc/xtensa/xtfpga-i2s.c+1 -10 replies
55/56ASoC: soc-dai: Remove set_fmt_new callbackinclude/sound/soc-dai.h sound/soc/soc-dai.c+1 -60 replies
56/56ASoC: simple-card-utils: Move snd_soc_component_is_codec to be localinclude/sound/soc-component.h sound/soc/generic/simple-card-utils.c+6 -63 replies

Reviews trailers per patch

5 of 56 patches have a Reviewed-by or Acked-by.

PatchKuninori MorimotoKrzysztof KozlowskiNicolas FrattaroliPeter Ujfalusi
1/56
2/56
3/56
4/56
5/56
6/56
7/56
8/56
9/56
10/56
11/56
12/56
13/56
14/56
15/56
16/56
17/56
18/56T-b
19/56
20/56A-b
21/56
22/56
23/56
24/56A-b
25/56A-b
26/56
27/56
28/56
29/56
30/56
31/56
32/56
33/56
34/56
35/56
36/56
37/56
38/56
39/56
40/56
41/56
42/56
43/56
44/56
45/56
46/56A-b
47/56
48/56
49/56
50/56
51/56
52/56A-b
53/56
54/56
55/56
56/56

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/56] Specify clock provider directly to CPU DAIs

Currently the set_fmt callback always passes clock provider/consumer with respect to the CODEC. This made sense when the framework was directly broken down into platforms and CODECs. However, as things are now broken down into components which can be connected as either the CPU or CODEC side of a DAI link it simplifies things if each side of the link is just told if it is provider or consumer of the clocks. Making this change allows us to remove one of the last parts of the ASoC core that needs to know if a driver is a CODEC driver, where it flips the clock format specifier if a CODEC driver is used on the CPU side of a DAI link, as well as just being conceptually more consistent with componentisation.

The basic idea of this patch chain is to change the set_fmt callback from specifying if the CODEC is provider/consumer into directly specifying if the component is provider/consumer. To do this we add some new defines, and then to preserve bisectability, the migration is done by adding a new callback, converting over all existing CPU side drivers, converting the core, and then finally reverting back to the old callback.

Converting the platform drivers makes sense as the existing defines are from the perspective of the CODEC and there are more CODEC drivers than platform drivers.

Obviously a fair amount of this patch chain I was only able to build test, so any testing that can be done would be greatly appreciated.

Thanks,
Charles

Charles Keepax (56):
ASoC: core: Add set_fmt_new callback that directly specifies provider
ASoC: amd: vangogh: Update to use set_fmt_new callback
ASoC: atmel: Update to use set_fmt_new callback
ASoC: au1x: Update to use set_fmt_new callback
ASoC: bcm: Update to use set_fmt_new callback
ASoC: ep93xx: Update to use set_fmt_new callback
ASoC: dwc: Update to use set_fmt_new callback
ASoC: fsl: Update to use set_fmt_new callback
ASoC: hisilicon: Update to use set_fmt_new callback
ASoC: img: Update to use set_fmt_new callback
ASoC: Intel: Update to use set_fmt_new callback
ASoC: js4740-i2s: Update to use set_fmt_new callback
ASoC: mediatek: Update to use set_fmt_new callback
ASoC: meson: Update to use set_fmt_new callback
ASoC: mxs-saif: Update to use set_fmt_new callback
ASoC: pxa: Update to use set_fmt_new callback
ASoC: qcom: Update to use set_fmt_new callback
ASoC: rockchip: Update to use set_fmt_new callback
ASoC: samsung: Update to use set_fmt_new callback
ASoC: sh: Update to use set_fmt_new callback
ASoC: stm: Update to use set_fmt_new callback
ASoC: sunxi: Update to use set_fmt_new callback
ASoC: tegra: Update to use set_fmt_new callback
ASoC: test-component: Update to use set_fmt_new callback
ASoC: ti: Update to use set_fmt_new callback
ASoC: ux500: Update to use set_fmt_new callback
ASoC: xtensa: Update to use set_fmt_new callback
ASoC: core: Always send the CPU DAI a direct clock specifier
ASoC: amd: vangogh: Rename set_fmt_new back to set_fmt
ASoC: atmel: Rename set_fmt_new back to set_fmt
ASoC: au1x: Rename set_fmt_new back to set_fmt
ASoC: bcm: Rename set_fmt_new back to set_fmt
ASoC: ep93xx: Rename set_fmt_new back to set_fmt
ASoC: dwc: Rename set_fmt_new back to set_fmt
ASoC: fsl: Rename set_fmt_new back to set_fmt
ASoC: hisilicon: Rename set_fmt_new back to set_fmt
ASoC: img: Rename set_fmt_new back to set_fmt
ASoC: Intel: Rename set_fmt_new back to set_fmt
ASoC: jz4740-i2s: Rename set_fmt_new back to set_fmt
ASoC: mediatek: Rename set_fmt_new back to set_fmt
ASoC: meson: Rename set_fmt_new back to set_fmt
ASoC: mxs-saif: Rename set_fmt_new back to set_fmt
ASoC: pxa: Rename set_fmt_new back to set_fmt
ASoC: qcom: Rename set_fmt_new back to set_fmt
ASoC: rockchip: Rename set_fmt_new back to set_fmt
ASoC: samsung: Rename set_fmt_new back to set_fmt
ASoC: sh: Rename set_fmt_new back to set_fmt
ASoC: stm: Rename set_fmt_new back to set_fmt
ASoC: sunxi: Rename set_fmt_new back to set_fmt
ASoC: tegra: Rename set_fmt_new back to set_fmt
ASoC: test-component: Rename set_fmt_new back to set_fmt
ASoC: ti: Rename set_fmt_new back to set_fmt
ASoC: ux500: Rename set_fmt_new back to set_fmt
ASoC: xtensa: Rename set_fmt_new back to set_fmt
ASoC: soc-dai: Remove set_fmt_new callback
ASoC: simple-card-utils: Move snd_soc_component_is_codec to be local

 include/sound/soc-component.h                |  5 ---
 include/sound/soc-dai.h                      |  6 ++++
 sound/soc/amd/vangogh/acp5x-i2s.c            |  4 +--
 sound/soc/atmel/atmel-i2s.c                  |  4 +--
 sound/soc/atmel/atmel_ssc_dai.c              | 18 +++++-----
 sound/soc/atmel/mchp-i2s-mcc.c               |  8 ++---
 sound/soc/atmel/mchp-pdmc.c                  |  4 +--
 sound/soc/au1x/i2sc.c                        |  2 +-
 sound/soc/au1x/psc-i2s.c                     |  4 +--
 sound/soc/bcm/bcm2835-i2s.c                  | 20 +++++------
 sound/soc/bcm/cygnus-ssp.c                   |  4 +--
 sound/soc/cirrus/ep93xx-i2s.c                |  4 +--
 sound/soc/dwc/dwc-i2s.c                      |  8 ++---
 sound/soc/fsl/fsl_audmix.c                   |  6 ++--
 sound/soc/fsl/fsl_esai.c                     |  8 ++---
 sound/soc/fsl/fsl_mqs.c                      |  2 +-
 sound/soc/fsl/fsl_sai.c                      |  8 ++---
 sound/soc/fsl/fsl_ssi.c                      | 22 ++++++------
 sound/soc/fsl/imx-audmix.c                   |  4 +--
 sound/soc/fsl/imx-card.c                     |  2 +-
 sound/soc/generic/simple-card-utils.c        |  7 +++-
 sound/soc/generic/test-component.c           | 18 +++++-----
 sound/soc/hisilicon/hi6210-i2s.c             | 18 +++++-----
 sound/soc/img/img-i2s-in.c                   |  4 +--
 sound/soc/img/img-i2s-out.c                  |  6 ++--
 sound/soc/intel/atom/sst-atom-controls.c     |  4 +--
 sound/soc/intel/boards/bytcht_cx2072x.c      |  2 +-
 sound/soc/intel/boards/bytcht_da7213.c       |  2 +-
 sound/soc/intel/boards/bytcht_es8316.c       |  2 +-
 sound/soc/intel/boards/bytcht_nocodec.c      |  2 +-
 sound/soc/intel/boards/bytcr_rt5640.c        |  2 +-
 sound/soc/intel/boards/bytcr_rt5651.c        |  2 +-
 sound/soc/intel/boards/bytcr_wm5102.c        |  2 +-
 sound/soc/intel/boards/cht_bsw_max98090_ti.c |  3 +-
 sound/soc/intel/boards/cht_bsw_rt5645.c      |  6 ++--
 sound/soc/intel/boards/cht_bsw_rt5672.c      |  2 +-
 sound/soc/intel/keembay/kmb_platform.c       |  4 +--
 sound/soc/jz4740/jz4740-i2s.c                | 10 +++---
 sound/soc/mediatek/mt8195/mt8195-dai-etdm.c  |  6 ++--
 sound/soc/mediatek/mt8195/mt8195-dai-pcm.c   |  6 ++--
 sound/soc/meson/aiu-encoder-i2s.c            |  2 +-
 sound/soc/meson/axg-tdm-interface.c          | 14 ++++----
 sound/soc/mxs/mxs-saif.c                     |  4 +--
 sound/soc/pxa/magician.c                     |  8 ++---
 sound/soc/pxa/mmp-sspa.c                     |  6 ++--
 sound/soc/pxa/pxa-ssp.c                      | 22 ++++++------
 sound/soc/pxa/pxa2xx-i2s.c                   |  6 ++--
 sound/soc/qcom/apq8016_sbc.c                 |  2 +-
 sound/soc/qcom/qdsp6/audioreach.c            |  4 +--
 sound/soc/qcom/qdsp6/q6afe.c                 |  6 ++--
 sound/soc/qcom/sc7180.c                      |  2 +-
 sound/soc/qcom/sdm845.c                      |  6 ++--
 sound/soc/qcom/sm8250.c                      |  4 +--
 sound/soc/rockchip/rockchip_i2s.c            |  6 ++--
 sound/soc/rockchip/rockchip_i2s_tdm.c        |  6 ++--
 sound/soc/samsung/i2s.c                      |  6 ++--
 sound/soc/samsung/pcm.c                      |  4 +--
 sound/soc/samsung/s3c-i2s-v2.c               |  6 ++--
 sound/soc/samsung/s3c24xx-i2s.c              |  6 ++--
 sound/soc/sh/fsi.c                           |  6 ++--
 sound/soc/sh/rcar/core.c                     |  4 +--
 sound/soc/sh/rz-ssi.c                        |  2 +-
 sound/soc/sh/ssi.c                           | 10 +++---
 sound/soc/soc-core.c                         | 14 ++------
 sound/soc/soc-dai.c                          |  3 +-
 sound/soc/stm/stm32_i2s.c                    |  8 ++---
 sound/soc/stm/stm32_sai_sub.c                |  8 ++---
 sound/soc/sunxi/sun4i-i2s.c                  | 18 +++++-----
 sound/soc/sunxi/sun8i-codec.c                |  6 ++--
 sound/soc/tegra/tegra20_i2s.c                |  6 ++--
 sound/soc/tegra/tegra210_i2s.c               |  6 ++--
 sound/soc/tegra/tegra30_i2s.c                |  6 ++--
 sound/soc/ti/davinci-i2s.c                   | 32 ++++++++---------
 sound/soc/ti/davinci-mcasp.c                 | 10 +++---
 sound/soc/ti/omap-mcbsp.c                    | 12 +++----
 sound/soc/ux500/ux500_msp_dai.c              | 36 ++++++++++----------
 sound/soc/xtensa/xtfpga-i2s.c                |  4 +--
 77 files changed, 279 insertions(+), 283 deletions(-)
Signature · 7 lines
2.30.2


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic