Skip to content

Bug fixes for mdadm tests

Logan Gunthorpe linux-raid lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 6 repliesIn review
  2. v311 patches 5 repliesSuperseded
  3. v217 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v115 patches25 repliesSuperseded

Changes in v4 from the cover letter

* Collected Reviewed-by Tags from Christoph
* Removed lockdep_assert_held() that didn't belong in patch (per Christoph)
* Moved the last patch to the beginning

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11md/raid5-ppl: Fix argument order in bio_alloc_bioset()drivers/md/raid5-ppl.c+2 -22 replies
2/11md/raid5-log: Drop extern decorators for function prototypesdrivers/md/raid5-log.h+36 -390 replies
3/11md/raid5-ppl: Drop unused argument from ppl_handle_flush_request()drivers/md/raid5-log.h drivers/md/raid5-ppl.c+3 -30 replies
4/11md/raid5: Ensure array is suspended for calls to log_exit()drivers/md/raid5.c+6 -124 replies
5/11md/raid5-cache: Take mddev_lock in r5c_journal_mode_show()drivers/md/raid5-cache.c+9 -60 replies
6/11md/raid5-cache: Drop RCU usage of conf->logdrivers/md/raid5-cache.c+5 -110 replies
7/11md/raid5-cache: Clear conf->log after finishing workdrivers/md/raid5-cache.c+3 -20 replies
8/11md/raid5-cache: Annotate pslot with __rcu notationdrivers/md/raid5-cache.c+2 -20 replies
9/11md: Use enum for overloaded magic numbers used by mddev->curr_resyncdrivers/md/md.c drivers/md/md.h+33 -220 replies
10/11md: Ensure resync is reported after it startsdrivers/md/md.c+12 -20 replies
11/11md: Notify sysfs sync_completed in md_reap_sync_thread()drivers/md/md.c+1 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/11] Bug fixes for mdadm tests

Hi,

This is the updated series with the feedback received in v3[1].

This series includes fixes to fix all the kernel panics in the mdadm tests and some, related, sparse issues, plus some cleanup.

Patches 2 and 3 are cleanup from the original series that aren't related now but I thought are worth including.

Patches 4 through 7 fix bugs with conf->log and remove the single, unecessary, RCU access. This cleans up some sparse errors.

Patch 8 cleans up some sparse warnings with pslot usage.

Patch 9 is a cleanup which adds an enum so that patch 10 can fix an mdadm hang. Patch 11 also fixes an mdadm hang.

I've also included Patch 1 in this series which fixes a recent mistake in raid5-ppl that was reported by 0day which I don't think has been fixed yet.

This series will be followed by another series for mdadm which fixes the segfaults and annotates some failing tests to make mdadm tests runnable fairly reliably, but I'll wait for a stable hash for this series to note the kernel version tested against. Following that, v3 of my lock contention series will be sent with more confidence of its correctness.

This series is based on the current md/md-next branch as of yesterday (42b805af10). A git branch is available here:

https://github.com/sbates130272/linux-p2pmem md-bug_v4

Thanks,

Logan

[1] https://lore.kernel.org/all/[email protected]

--

Changes since v3:
* Collected Reviewed-by Tags from Christoph
* Removed lockdep_assert_held() that didn't belong in patch (per Christoph)
* Moved the last patch to the beginning

Changes since v2:
* Rework the RCU changes to remove the RCU usage instead of using it every. This makes more sense seeing most accesses do not need RCU due to them being on the IO path, or with mddev_lock() held and the remaining ones are on the slow path and may use mddev_lock(). (Per Christoph)
* Collect a couple more Reviewed-by tags from Christoph

Changes since v1:
* Add a patch to move the struct r5l_log to raid5-log.h in order to fix a compiler error with rcu_access_pointer() in versions prior to gcc-10
* Rework r5c_is_writeback() changes to make less churn (per Christoph)
* Change some 1s to trues in rcu_dereference_protected calls (per Christoph)
* Fix an odd hunk mistake in the RCU protection patch (per Christoph)
* Fix an inverted conditional (noticed by Donald)
* Add a patch to add an enum for the overloaded values used by

    mddev->curr_resync to make the status_resync() fixes clearer
    (per Christoph)

--

Logan Gunthorpe (11):
md/raid5-ppl: Fix argument order in bio_alloc_bioset() md/raid5-log: Drop extern decorators for function prototypes md/raid5-ppl: Drop unused argument from ppl_handle_flush_request() md/raid5: Ensure array is suspended for calls to log_exit() md/raid5-cache: Take mddev_lock in r5c_journal_mode_show() md/raid5-cache: Drop RCU usage of conf->log md/raid5-cache: Clear conf->log after finishing work md/raid5-cache: Annotate pslot with __rcu notation
md: Use enum for overloaded magic numbers used by mddev->curr_resync
md: Ensure resync is reported after it starts
md: Notify sysfs sync_completed in md_reap_sync_thread()

 drivers/md/md.c          | 55 +++++++++++++++-------------
 drivers/md/md.h          | 15 ++++++++
 drivers/md/raid5-cache.c | 40 ++++++++++-----------
 drivers/md/raid5-log.h   | 77 +++++++++++++++++++---------------------
 drivers/md/raid5-ppl.c   |  6 ++--
 drivers/md/raid5.c       | 18 ++++------
 6 files changed, 111 insertions(+), 100 deletions(-)

base-commit: 92a045f71a3c6767a7f30c0d80d2e4f6d5d49d77 --
2.30.2