Skip to content

fstests: fix a major test setup performance regression

Dave Chinner fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fstests: tests should not source common/rc directlytests/btrfs/243 tests/btrfs/245 tests/ext4/053 +7 more+0 -102 replies
2/2common/rc: fix test init performance regression on XFScommon/rc common/xfs+12 -132 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongZorro LangChristian Brauner (Microsoft)
1/2R-b A-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] fstests: fix a major test setup performance regression

Hi folks,

I've been seeing symptoms of this issue described in patch 2 for most of this merge cycle, and it's slowly been getting worse, to the point where I had to fix it to be able to get any amount of testing done. Turns out we're doing something that is not smart with XFS test setup, and recent changes to mkfs.xfs caused that to be exposed. These patches fix it.

The first patch is a cleanup - no test should be including common/rc directly anymore - _being_fstest() does that now. The second patch fixes the XFS issues in init_rc() which is called from _begin_fstest when is sources common/rc....

Cheers,

Dave.