Add group constraints and event code test as part of selftest
Status from this message: Applied to powerpc/next.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest35 patches 1 replyApplied
- v235 patches 0 repliesSuperseded
Changes in v3 from the cover letter
Changed name for generic compat PMU to ISAv3 in Patch2. This is based on recent patch sent by Joel Stanley to change name for generic_compat_pmu to ISAv3.
http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=304131
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/35 | selftest/powerpc/pmu: Add mask/shift bits for extracting threshold compare fieldtools/ tools/ | +45 | 0 replies | |
| 2/35 | testing/selftests/powerpc: Add support to fetch "platform" and "base platform" from auxv to detect platform.tools/ tools/ tools/ | +63 | 0 replies | |
| 3/35 | selftest/powerpc/pmu: Add interface test for mmcra_thresh_cmp fieldstools/ tools/ | +75 | 0 replies | |
| 4/35 | selftest/powerpc/pmu: Add support for branch sampling in get_intr_regs functiontools/ | +20 | 0 replies | |
| 5/35 | selftest/powerpc/pmu: Add interface test for mmcra_ifm field of indirect call typetools/ tools/ tools/ | +100 | 0 replies | |
| 6/35 | selftest/powerpc/pmu: Add interface test for mmcra_ifm field for any branch typetools/ tools/ | +66 | 0 replies | |
| 7/35 | selftest/powerpc/pmu: Add interface test for mmcra_ifm field for conditional branch typetools/ tools/ | +70 | 0 replies | |
| 8/35 | selftest/powerpc/pmu: Add interface test for bhrb disable fieldtools/ tools/ tools/ | +69 | 0 replies | |
| 9/35 | selftest/powerpc/pmu: Refactor the platform check and add macros to find array size/PVRtools/ tools/ tools/ | +23 | 0 replies | |
| 10/35 | selftest/powerpc/pmu: Add selftest to check branch stack enablement will not crash on any platformstools/ tools/ | +60 | 0 replies | |
| 11/35 | selftest/powerpc/pmu: Add selftest to check PERF_SAMPLE_REGS_INTR option will not crash on any platformstools/ tools/ | +58 | 0 replies | |
| 12/35 | selftest/powerpc/pmu: Add selftest for checking valid and invalid bhrb filter mapstools/ tools/ | +107 | 0 replies | |
| 13/35 | selftest/powerpc/pmu: Add selftest for mmcr1 pmcxsel/unit/cache fieldstools/ tools/ | +78 | 0 replies | |
| 14/35 | selftest/powerpc/pmu: Add interface test for bhrb disable field for non-branch samplestools/ tools/ | +65 | 0 replies | |
| 15/35 | selftest/powerpc/pmu: Add support for perf event code teststools/ tools/ | +18 | 0 replies | |
| 16/35 | selftest/powerpc/pmu: Add selftest for group constraint check for PMC5 and PMC6tools/ tools/ | +64 | 0 replies | |
| 17/35 | selftest/powerpc/pmu: Add selftest to check PMC5/6 is excluded from some constraint checkstools/ tools/ | +65 | 0 replies | |
| 18/35 | selftest/powerpc/pmu: Add selftest to check constraint for number of counters in use.tools/ tools/ | +71 | 0 replies | |
| 19/35 | selftest/powerpc/pmu: Add selftest for group constraint check when using same PMCtools/ tools/ | +58 | 0 replies | |
| 20/35 | selftest/powerpc/pmu: Add selftest for group constraint check for radix_scope_qual fieldtools/ tools/ | +57 | 0 replies | |
| 21/35 | selftest/powerpc/pmu: Add selftest for group constraint for MMCRA Sampling Mode fieldtools/ tools/ | +78 | 0 replies | |
| 22/35 | selftest/powerpc/pmu: Add selftest for group constraint check MMCRA sample bitstools/ tools/ | +56 | 0 replies | |
| 23/35 | selftest/powerpc/pmu: Add selftest for checking invalid bits in event codetools/ tools/ | +68 | 0 replies | |
| 24/35 | selftest/powerpc/pmu: Add selftest for reserved bit check for MMCRA thresh_ctl fieldtools/ tools/ | +45 | 0 replies | |
| 25/35 | selftest/powerpc/pmu: Add selftest for blacklist events check in power9tools/ tools/ | +134 | 0 replies | |
| 26/35 | selftest/powerpc/pmu: Add selftest for event alternatives for power9tools/ tools/ | +117 | 0 replies | |
| 27/35 | selftest/powerpc/pmu: Add selftest for event alternatives for power10tools/ tools/ | +110 | 0 replies | |
| 28/35 | selftest/powerpc/pmu: Add selftest for PERF_TYPE_HARDWARE events valid checktools/ tools/ | +131 | 0 replies | |
| 29/35 | selftest/powerpc/pmu: Add selftest for group constraint check for MMCR0 l2l3_sel bitstools/ tools/ | +66 | 0 replies | |
| 30/35 | selftest/powerpc/pmu: Add selftest for group constraint check for MMCR1 cache bitstools/ tools/ | +61 | 0 replies | |
| 31/35 | selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_cmp fieldtools/ tools/ | +97 | 0 replies | |
| 32/35 | selftest/powerpc/pmu: Add selftest for group constraint for unit and pmc field in p9tools/ tools/ | +76 | 0 replies | |
| 33/35 | selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_ctl fieldtools/ tools/ | +65 | 0 replies | |
| 34/35 | selftest/powerpc/pmu: Add selftest for group constraint check for MMCRA thresh_sel fieldtools/ tools/ | +64 | 0 replies | |
| 35/35 | selftest/powerpc/pmu: Add test for hardware cache eventstools/ tools/ | +90 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH V3 00/35] Add group constraints and event code test as part of selftest
Patch series extends the perf interface selftests to cover scenarios for event code checking, group constraints, and also thresholding/branch related interface tests in sampling area.
In this series, patches 1 to 14 adds additional tests under "powerpc/sampling_tests". These adds support for handling sample type PERF_SAMPLE_BRANCH_STACK along with interrupt regs. It adds utility functions and test for thresh_cmp and branch filters programmed in control register. Some of the tests needs to be skipped for "Generic Compat PMU" environment. Hence utility functions are added in "include/utils.c" and "sampling_tests/misc.h" to detect platform based on "auxv" entries.
Currently in other architectures (like x86), the pmu_name is exposed via sysfs caps folder ie:
"sys/bus/event_source/devices/<pmu>/caps". But in powerpc, "caps" is not supported. So, though the approach for detecting compat mode currently uses auxv, patchset adds an utility function considering a possibility of getting "caps" added for powerpc.
Link to the patch to add support for caps under sysfs in powerpc:
http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=301270
Patches 15 to 35 covers test related to group constraints and event codes. These new set of changes are added under new folder:
"selftests/powerpc/pmu/event_code_tests"
Patch 15 covers changes required for new folder with Makefile changes. The other patches add tests for perf interface to check the event group constraints, valid/invalid event codes, blacklisted events etc. Also add required utility functions under header file "misc.h" in sampling_tests folder.
Patch 13 of the patchset add selftest for mmcr1 pmcxsel/unit/cache fields, which was initially dropeed from sampling test patchset (patch number: 16)
Link to the patch:
http://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/
Changelog:
v2 -> v3:
Changed name for generic compat PMU to ISAv3 in Patch2. This is based on recent patch sent by Joel Stanley to change name for generic_compat_pmu to ISAv3.
http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=304131
v1 -> v2:
Patch 12: Fixed bhrb_filter_map testcase to address build failure in distro like Ubuntu 16.04. This testcase uses perf branch sample types from include/uapi/linux/perf_event.h and three of the sample types are not defined in Ubuntu 16.04. Hence changed the logic to loop over values from PERF_SAMPLE_BRANCH_USER_SHIFT to PERF_SAMPLE_BRANCH_MAX_SHIFT as suggested by Michael Ellerman.
Patch 2: The sampling_tests/misc.c used pmu_name for generic compat pmu as generic_compat_pmu. But latest version of patch to expose caps in powerpc will use power_pmu->name. So change the pmu name in misc code as GENERIC_COMPAT ( which is what pmu->name uses in driver code).
Link to linuxppc-ci:
https://github.com/athira-rajeev/linux-ci/actions?query=branch%3Aselftest_v5_set2
Athira Rajeev (20):
testing/selftests/powerpc: Add support to fetch "platform" and "base
platform" from auxv to detect platform.
selftest/powerpc/pmu: Refactor the platform check and add macros to
find array size/PVR
selftest/powerpc/pmu: Add selftest to check branch stack enablement
will not crash on any platforms
selftest/powerpc/pmu: Add selftest to check PERF_SAMPLE_REGS_INTR
option will not crash on any platforms
selftest/powerpc/pmu: Add selftest for checking valid and invalid bhrb
filter maps
selftest/powerpc/pmu: Add selftest for mmcr1 pmcxsel/unit/cache fields selftest/powerpc/pmu: Add support for perf event code tests selftest/powerpc/pmu: Add selftest for group constraint check for PMC5
and PMC6
selftest/powerpc/pmu: Add selftest to check PMC5/6 is excluded from
some constraint checks
selftest/powerpc/pmu: Add selftest to check constraint for number of
counters in use.
selftest/powerpc/pmu: Add selftest for group constraint check when
using same PMC
selftest/powerpc/pmu: Add selftest for group constraint check for
radix_scope_qual field
selftest/powerpc/pmu: Add selftest for group constraint for MMCRA
Sampling Mode field
selftest/powerpc/pmu: Add selftest for group constraint check MMCRA
sample bits
selftest/powerpc/pmu: Add selftest for checking invalid bits in event
code
selftest/powerpc/pmu: Add selftest for reserved bit check for MMCRA
thresh_ctl field
selftest/powerpc/pmu: Add selftest for blacklist events check in
power9
selftest/powerpc/pmu: Add selftest for event alternatives for power9 selftest/powerpc/pmu: Add selftest for event alternatives for power10 selftest/powerpc/pmu: Add selftest for PERF_TYPE_HARDWARE events valid
check
Kajol Jain (15):
selftest/powerpc/pmu: Add mask/shift bits for extracting threshold
compare field
selftest/powerpc/pmu: Add interface test for mmcra_thresh_cmp fields selftest/powerpc/pmu: Add support for branch sampling in get_intr_regs
function
selftest/powerpc/pmu: Add interface test for mmcra_ifm field of
indirect call type
selftest/powerpc/pmu: Add interface test for mmcra_ifm field for any
branch type
selftest/powerpc/pmu: Add interface test for mmcra_ifm field for
conditional branch type
selftest/powerpc/pmu: Add interface test for bhrb disable field selftest/powerpc/pmu: Add interface test for bhrb disable field for
non-branch samples
selftest/powerpc/pmu: Add selftest for group constraint check for
MMCR0 l2l3_sel bits
selftest/powerpc/pmu: Add selftest for group constraint check for
MMCR1 cache bits
selftest/powerpc/pmu: Add selftest for group constraint check for
MMCRA thresh_cmp field
selftest/powerpc/pmu: Add selftest for group constraint for unit and
pmc field in p9
selftest/powerpc/pmu: Add selftest for group constraint check for
MMCRA thresh_ctl field
selftest/powerpc/pmu: Add selftest for group constraint check for
MMCRA thresh_sel field
selftest/powerpc/pmu: Add test for hardware cache events
tools/testing/selftests/powerpc/include/reg.h | 4 + .../testing/selftests/powerpc/include/utils.h | 10 ++ tools/testing/selftests/powerpc/pmu/Makefile | 11 +- .../selftests/powerpc/pmu/branch_loops.S | 28 ++++ .../powerpc/pmu/event_code_tests/Makefile | 15 ++ .../blacklisted_events_test.c | 132 +++++++++++++++++ .../event_alternatives_tests_p10.c | 109 ++++++++++++++ .../event_alternatives_tests_p9.c | 116 +++++++++++++++ .../generic_events_valid_test.c | 130 +++++++++++++++++ .../group_constraint_cache_test.c | 60 ++++++++ .../group_constraint_l2l3_sel_test.c | 64 +++++++++ .../group_constraint_mmcra_sample_test.c | 54 +++++++ .../group_constraint_pmc56_test.c | 63 ++++++++ .../group_constraint_pmc_count_test.c | 70 +++++++++ .../group_constraint_radix_scope_qual_test.c | 56 ++++++++ .../group_constraint_repeat_test.c | 56 ++++++++ .../group_constraint_thresh_cmp_test.c | 96 +++++++++++++ .../group_constraint_thresh_ctl_test.c | 64 +++++++++ .../group_constraint_thresh_sel_test.c | 63 ++++++++ .../group_constraint_unit_test.c | 74 ++++++++++ .../group_pmc56_exclude_constraints_test.c | 64 +++++++++ .../hw_cache_event_type_test.c | 88 ++++++++++++ .../invalid_event_code_test.c | 67 +++++++++ ...eserved_bits_mmcra_sample_elig_mode_test.c | 77 ++++++++++ .../reserved_bits_mmcra_thresh_ctl_test.c | 44 ++++++ .../powerpc/pmu/sampling_tests/Makefile | 7 +- .../pmu/sampling_tests/bhrb_filter_map_test.c | 105 ++++++++++++++ .../bhrb_no_crash_wo_pmu_test.c | 59 ++++++++ .../intr_regs_no_crash_wo_pmu_test.c | 57 ++++++++ .../powerpc/pmu/sampling_tests/misc.c | 135 +++++++++++++++++- .../powerpc/pmu/sampling_tests/misc.h | 9 +- .../mmcr1_sel_unit_cache_test.c | 77 ++++++++++ .../pmu/sampling_tests/mmcra_bhrb_any_test.c | 65 +++++++++ .../pmu/sampling_tests/mmcra_bhrb_cond_test.c | 69 +++++++++ .../mmcra_bhrb_disable_no_branch_test.c | 64 +++++++++ .../sampling_tests/mmcra_bhrb_disable_test.c | 66 +++++++++ .../sampling_tests/mmcra_bhrb_ind_call_test.c | 69 +++++++++ .../sampling_tests/mmcra_thresh_cmp_test.c | 74 ++++++++++ 38 files changed, 2461 insertions(+), 10 deletions(-) create mode 100644 tools/testing/selftests/powerpc/pmu/branch_loops.S create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/Makefile create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/blacklisted_events_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/event_alternatives_tests_p10.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/event_alternatives_tests_p9.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/generic_events_valid_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_cache_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_l2l3_sel_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_mmcra_sample_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_pmc56_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_pmc_count_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_radix_scope_qual_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_repeat_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_cmp_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_ctl_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_thresh_sel_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_constraint_unit_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/group_pmc56_exclude_constraints_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/hw_cache_event_type_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/invalid_event_code_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/reserved_bits_mmcra_sample_elig_mode_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/event_code_tests/reserved_bits_mmcra_thresh_ctl_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_filter_map_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/bhrb_no_crash_wo_pmu_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/intr_regs_no_crash_wo_pmu_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcr1_sel_unit_cache_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_any_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_cond_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_disable_no_branch_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_disable_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_bhrb_ind_call_test.c create mode 100644 tools/testing/selftests/powerpc/pmu/sampling_tests/mmcra_thresh_cmp_test.c
Signature · 1 line
2.35.1