Skip to content

fix uncallable unit tests (Bugzilla 1002)

Bruce Richardson dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 5 repliesSuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

* Fix feedback from Olivier's review
* Fix typo in spelling of "binary" (binrary) in patch 2 commit log

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cmdline: add function to verify valid commandslib/cmdline/cmdline_parse.c lib/cmdline/cmdline_parse.h lib/cmdline/version.map+38 -100 replies
2/2test: use cmdline library to validate argsapp/test/commands.c app/test/test.c+7 -280 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchWeiyuan LiOlivier Matz
1/2T-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] fix uncallable unit tests (Bugzilla 1002)

The dump* unit tests are uncallable from our test framework because the command validation in the unit test binary is incorrect. Rather than trying to fix this directly in the binary, a better approach is to add command validation to the cmdline library - which already has 99% of what we need already - and use that from the test app.

Patch fix not CC'ed to stable, as fix requires new function in cmdline library.

V3:
* Fix feedback from Olivier's review
* Fix typo in spelling of "binary" (binrary) in patch 2 commit log

V2:
* Fix checkpatch issues

Bruce Richardson (2):
cmdline: add function to verify valid commands
test: use cmdline library to validate args

 app/test/commands.c         | 11 -----------
 app/test/test.c             | 24 +++++++-----------------
 lib/cmdline/cmdline_parse.c | 28 ++++++++++++++++++++--------
 lib/cmdline/cmdline_parse.h | 17 +++++++++++++++--
 lib/cmdline/version.map     |  3 +++
 5 files changed, 45 insertions(+), 38 deletions(-)

--
2.34.1