Cleanup transhuge_xxx helpers
Status from this message: [merged mm-stable] doc-proc-fix-the-description-to-thpeligible.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest7 patches 9 repliesApplied 7/7
- v47 patches 7 repliesSuperseded
- v37 patches 32 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 7 patches | 2 replies | Superseded | |
| v1 | 7 patches | 2 replies | Superseded |
Patches in v5 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | mm: khugepaged: check THP flag in hugepage_vma_check()mm/ | +3 | 0 replies | Applied |
| 2/7 | mm: thp: consolidate vma size check to transhuge_vma_suitableinclude/ include/ mm/ +1 more | +18 | 0 replies | Applied |
| 3/7 | mm: khugepaged: better comments for anon vma check in hugepage_vma_revalidatemm/ | +7 | 0 replies | Applied |
| 4/7 | mm: thp: kill transparent_hugepage_active()fs/ include/ include/ +2 more | +56 | 3 replies | Applied |
| 5/7 | mm: thp: kill __transhuge_page_enabled()fs/ include/ mm/ +2 more | +52 | 0 replies | Applied |
| 6/7 | mm: khugepaged: reorg some khugepaged helpersinclude/ include/ mm/ +1 more | +21 | 0 replies | Applied |
| 7/7 | doc: proc: fix the description to THPeligibleDocumentation/ | +3 | 0 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Zach O'Keefe | Miaohe Lin |
|---|---|---|
| 1/7 | R-b | R-b |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [mm-unstable v5 PATCH 0/7] Cleanup transhuge_xxx helpers
v5: * Removed transparent_hugepage_active() for !THP, per Zach.
Patch 4/7 and 5/7 were updated accordingly.
* Collected review tags.
v4: * Consolidated the transhuge_vma_size_ok() helper proposed in the
earlier versions into transhuge_vma_suitable(), per Zach.
* Fixed the regression introduced by patch 3/7, per Zach and Miaohe.
* Reworded the comment for transhuge_vma_suitable(), per Zach.
* Removed khugepaged_enter() per Miaohe.
* More comments for hugepage_vma_check(), per Zach.
* Squashed patch 4/7 (mm: khugepaged: use transhuge_vma_suitable replace open-code) in the earlier version into patch 2/7 of this version.
* Minor correction to the doc about THPeligible (patch 7/7), so the total number of patches is kept 7.
v3: * Fixed the comment from Willy
v2: * Rebased to the latest mm-unstable
* Fixed potential regression for smaps's THPeligible
This series is the follow-up of the discussion about cleaning up transhuge_xxx helpers at https://lore.kernel.org/linux-mm/[email protected]/.
THP has a bunch of helpers that do VMA sanity check for different paths, they do the similar checks for the most callsites and have a lot duplicate codes. And it is confusing what helpers should be used at what conditions.
This series reorganized and cleaned up the code so that we could consolidate all the checks into hugepage_vma_check().
The transhuge_vma_enabled(), transparent_hugepage_active() and __transparent_hugepage_enabled() are killed by this series.
Yang Shi (7):
mm: khugepaged: check THP flag in hugepage_vma_check()
mm: thp: consolidate vma size check to transhuge_vma_suitable
mm: khugepaged: better comments for anon vma check in hugepage_vma_revalidate
mm: thp: kill transparent_hugepage_active()
mm: thp: kill __transhuge_page_enabled()
mm: khugepaged: reorg some khugepaged helpers
doc: proc: fix the description to THPeligible
Documentation/filesystems/proc.rst | 4 ++- fs/proc/task_mmu.c | 2 +- include/linux/huge_mm.h | 80 +++++++++++++++++++---------------------------------------- include/linux/khugepaged.h | 30 ---------------------- mm/huge_memory.c | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++-------- mm/khugepaged.c | 84 +++++++++++++++++++------------------------------------------- mm/memory.c | 7 ++++-- 7 files changed, 130 insertions(+), 158 deletions(-)