Skip to content

xfs: small fixes for 5.19 cycle

Dave Chinner linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xfs: avoid unnecessary runtime sibling pointer endian conversionsfs/xfs/libxfs/xfs_btree.c+33 -142 replies
2/3xfs: don't assert fail on perag references on teardownfs/xfs/libxfs/xfs_ag.c+1 -24 replies
3/3xfs: assert in xfs_btree_del_cursor should take into account errorfs/xfs/libxfs/xfs_btree.c+7 -12 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph Hellwig
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] xfs: small fixes for 5.19 cycle

Hi folks,

In this series are two small changes to debug code that have made test runs a little more resilient for me over this cycle. One if a fix to an assert that is popping on an error handling path that doesn't take into account an error occurring. The other is to convert a hard ASSERT fail to a XFS_IS_CORRUPT check that will dump a failure to dmesg and fail tests taht way instead of hanging the machine by killing an unmount process.

The other patch is a small optimisation to the new btree sibling pointer checking. This explicitly inlines the new checking function, reducing the code size significantly and making the code simpler and faster to execute. This should address the small performance regressions reported on AIM7 workloads caused by the sibling checks.

Cheers,

Dave.