Skip to content

Bluetooth: btrtl: add support for the RTL8723CS

Bastian Germann linux-bluetooth lkml netdev 5 versions – Applied

Status from this message: This series was applied to bluetooth/bluetooth-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 1 replyApplied 2/2
  2. v52 patches 2 repliesSuperseded
  3. v42 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v32 patches3 repliesSuperseded
v23 patches4 repliesSuperseded

Changes in v6 from the cover letter

* Warn on active quirk

Patches in v6 All 2 applied

#Subject and filesSizeRepliesApplied
1/2Bluetooth: Add new quirk for broken local ext features page 2include/net/bluetooth/hci.h net/bluetooth/hci_event.c+14 -21 replyApplied
2/2Bluetooth: btrtl: add support for the RTL8723CSdrivers/bluetooth/btrtl.c drivers/bluetooth/btrtl.h drivers/bluetooth/hci_h5.c+125 -40 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/2] Bluetooth: btrtl: add support for the RTL8723CS

Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately, RTL8723CS has broken BT-4.1 support, so it requires a quirk.

Add a quirk and wire up 8723CS support in btrtl.
I was asked for a btmon output without the quirk;
however, using the chip without the quirk ends up in a bad state with "Opcode 0x c77 failed: -56" (HCI_OP_READ_SYNC_TRAIN_PARAMS) on training. A btmon output with the quirk active was already sent by Vasily.

v1 of this series was sent in July 2020 by Vasily Khoruzhick. I have tested it to work on the Pinebook.

Changelog:
v2:
* Rebase
* Add uart-has-rtscts to device tree as requested by reviewer
v3:
* Drop the device tree as it was split out and is already integrated.
* Rename the quirk as requested by reviewer Marcel Holtmann
v4:
* Use skb_pull_data as requested by reviewer Luiz Augusto von Dentz
v5:
* Make use of skb_pull_data's length check
v6:
* Warn on active quirk

Vasily Khoruzhick (2):
Bluetooth: Add new quirk for broken local ext features page 2
Bluetooth: btrtl: add support for the RTL8723CS

 drivers/bluetooth/btrtl.c   | 120 ++++++++++++++++++++++++++++++++++--
 drivers/bluetooth/btrtl.h   |   5 ++
 drivers/bluetooth/hci_h5.c  |   4 ++
 include/net/bluetooth/hci.h |   7 +++
 net/bluetooth/hci_event.c   |   9 ++-
 5 files changed, 139 insertions(+), 6 deletions(-)
Signature · 1 line
2.39.2