Skip to content

source fs specific common file properly

Zorro Lang fstests 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2common: source base fs specific common filecommon/config common/overlay common/rc+64 -481 reply
2/2tests: remove redundant common/$FSTYP importingtests/btrfs/177 tests/btrfs/258 tests/btrfs/259 +3 more+0 -65 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDave ChinnerAmir Goldstein
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] source fs specific common file properly

It starts with generic/402 always fails on overlayfs as:

QA output created by 402
./common/rc: line 2441: _xfs_timestamp_range: command not found ./common/rc: line 2403: [: syntax error: '-1' unexpected ./common/rc: line 2408: [: -le: unary operator expected ./common/rc: line 2441: _xfs_timestamp_range: command not found 0;0 != 1;1
0;0 != 1;1
Silence is golden

Due to if FSTYP is overlay, we only source common/overlay file. But we still need the helpers of the underlying filesystem. So I think we need to source the common/$OVL_BASE_FSTYP in common/overlay.

Besides overlayfs, I'd like to extend other uplying fs support its BASE_FSTYP, so other uplying fs (e.g. nfs, cifs, glusterfs ...) will do like this.

Thanks,
Zorro