Skip to content

tests, python: prepare to expand usage of test venv

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 19 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9python: update for mypy 0.950python/qemu/qmp/util.py python/setup.cfg+4 -10 replies
2/9tests: add "TESTS_PYTHON" variable to Makefiletests/Makefile.include+4 -30 replies
3/9tests: use python3 as the python executable nametests/Makefile.include+1 -11 reply
4/9tests: silence pip upgrade warnings during venv creationtests/Makefile.include+2 -21 reply
5/9tests: add quiet-venv-pip macrotests/Makefile.include+6 -64 replies
6/9tests: install "qemu" namespace package into venvtests/Makefile.include tests/avocado/avocado_qemu/__init__.py tests/avocado/virtio_check_params.py +2 more+7 -81 reply
7/9tests: use tests/venv to run basevm.py-based scriptstests/vm/Makefile.include tests/vm/basevm.py+10 -90 replies
8/9tests: add python3-venv to debian10.dockertests/docker/dockerfiles/debian10.docker+1 -05 replies
9/9tests: run 'device-crash-test' from tests/venv.gitlab-ci.d/buildtest.yml scripts/device-crash-test+16 -62 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchPaolo Bonzini
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] tests, python: prepare to expand usage of test venv

GitLab CI: https://gitlab.com/jsnow/qemu/-/pipelines/548326343

This series collects some of the uncontroversial elements that serve as pre-requisites for a later series that seeks to generate a testing venv by default.

This series makes the following material changes:

- Install the 'qemu' package into the avocado testing venv
- Use the avocado testing venv to run vm-tests
- Use the avocado testing venv to run device-crash-test

None of these changes impact 'make check'; these are all specialty tests that are not run by default. This series also doesn't change how iotests are run, doesn't add any new dependencies for SRPM builds, etc.

NOTE: patch 8 isn't strictly required for this series, but including it here "early" helps the subsequent series. Since the debian docker files are layered, testing downstream pipelines can fail because the base image is pulled from the main QEMU repo instead of the downstream.

In other words: I need this patch in origin/main in order to have the venv module available for later patches that will actually need it in our debian10 derivative images.

(in other-other-words: the 'clang-user' test *will* need it later.)

John Snow (9):
python: update for mypy 0.950
tests: add "TESTS_PYTHON" variable to Makefile
tests: use python3 as the python executable name
tests: silence pip upgrade warnings during venv creation
tests: add quiet-venv-pip macro
tests: install "qemu" namespace package into venv
tests: use tests/venv to run basevm.py-based scripts
tests: add python3-venv to debian10.docker
tests: run 'device-crash-test' from tests/venv

 .gitlab-ci.d/buildtest.yml               |  8 +++++---
 python/qemu/qmp/util.py                  |  4 +++-
 python/setup.cfg                         |  1 +
 scripts/device-crash-test                | 14 +++++++++++---
 tests/Makefile.include                   | 18 ++++++++++--------
 tests/avocado/avocado_qemu/__init__.py   | 11 +++++------
 tests/avocado/virtio_check_params.py     |  1 -
 tests/avocado/virtio_version.py          |  1 -
 tests/docker/dockerfiles/debian10.docker |  1 +
 tests/requirements.txt                   |  1 +
 tests/vm/Makefile.include                | 13 +++++++------
 tests/vm/basevm.py                       |  6 +++---
 12 files changed, 47 insertions(+), 32 deletions(-)
Signature · 1 line
2.34.1