Skip to content

fs: dlm: plock, recovery and API deprecation

Alexander Aring cluster-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/220 patches 0 repliesNew
  2. v1 posting 1/26 patches 0 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20fs: dlm: plock use list_first_entryfs/dlm/plock.c+1 -10 replies
2/20fs: dlm: remove may interrupted messagefs/dlm/plock.c+1 -10 replies
3/20fs: dlm: add pid to debug logfs/dlm/plock.c+2 -20 replies
4/20fs: dlm: change log output to debug againfs/dlm/plock.c+1 -10 replies
5/20fs: dlm: use dlm_plock_info for do_unlock_closefs/dlm/plock.c+6 -100 replies
6/20fs: dlm: change posix lock sigint handlingfs/dlm/plock.c+26 -30 replies
7/20fs: dlm: change ast and bast trace orderfs/dlm/ast.c+2 -20 replies
8/20fs: dlm: remove additional dereference of lkbsbfs/dlm/ast.c include/trace/events/dlm.h+5 -50 replies
9/20fs: dlm: add resource name to tracepointsfs/dlm/lock.c include/trace/events/dlm.h+94 -200 replies
10/20fs: dlm: add notes for recovery and membership handlingfs/dlm/member.c fs/dlm/recoverd.c+9 -10 replies
11/20fs: dlm: call dlm_lsop_recover_prep oncefs/dlm/member.c+10 -10 replies
12/20fs: dlm: let new_lockspace() wait until recoveryfs/dlm/dlm_internal.h fs/dlm/lockspace.c fs/dlm/member.c +1 more+20 -190 replies
13/20fs: dlm: handle recovery result outside of ls_recoverfs/dlm/recoverd.c+26 -160 replies
14/20fs: dlm: handle recovery -EAGAIN case as retryfs/dlm/recoverd.c+48 -230 replies
15/20fs: dlm: change -EINVAL recovery error to -EAGAINfs/dlm/dir.c+4 -00 replies
16/20fs: dlm: add comment about lkb IFL flagsfs/dlm/dlm_internal.h+8 -00 replies
17/20fs: dlm: remove warn waiter handlingfs/dlm/config.c fs/dlm/config.h fs/dlm/dlm_internal.h +3 more+0 -910 replies
18/20fs: dlm: remove timeout from dlm_user_adopt_orphanfs/dlm/lock.c fs/dlm/lock.h fs/dlm/user.c+2 -30 replies
19/20fs: dlm: add API deprecation warningfs/dlm/Kconfig fs/dlm/lockspace.c fs/dlm/netlink.c +1 more+35 -10 replies
20/20fs: dlm: don't use deprecated API by defaultfs/dlm/Makefile fs/dlm/config.c fs/dlm/config.h +5 more+118 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [PATCH RESEND v5.19-rc3 00/20] fs: dlm: plock, recovery and API deprecation

Hi,

this patch series is just a resend to push them to dlm/next. It contains mainly three things:

1. Users asking while using plocks on gfs2 why they see "dev_write no op...". I reproduced a similar output by calling "stress-ng --fcntl 100" and hitting ctrl-c. However I think this message is harmless. The message occurs if the plock kernel handling cannot find the plock operation which was requested anymore as the user send a reply. Hitting ctrl-c at the right place we will delete the original requests from a lookup datastructure. First I added patches to signal that those original requests operations were removed and that's why a possible lookup will fail. However it confuses users, this patch will change the plock handling that we never should delete a request on purpose. If a interruption was happened during a requests to the user space and back we will signal this requests got interrupted and ignore the requests and cleanup the plock handling after we get a reply from the user space back. If there are still "dev_write no op..." messages it will signal a bug.

2. Changes due recovery handling e.g. wait until recovery is done when recovery is triggered by dlm_new_lockspace() and try to run the recovery mechanism several times if -EAGAIN is returned.

3. Remove the dlm waiters warning and deprecate the internal DLM timeout handling for now which will be removed in kernel v5.22. Upcomming patches to libdlm will effect that the linked application will disable the use of the feature which will be deprecated now.

- Alex

changes since on mailinglist:
- remove null terminated resource name in dlm traces
- add commit msg why it's safe to access rsb->res_name in traces
- move -EAGAIN in dlm_recover_directory() call (if -EINVAL is returned)
- remove patch "fs: dlm: add WARN_ON for non waiter case"
- remove patch "fs: dlm: add dlm_is_member() check if fenced"
- add "not" in comment about lkb IFL flags
- remove prototype of function which is removed in patch "fs: dlm: remove warn waiter handling"
- change prototype to static inline in patch
"fs: dlm: don't use deprecated API by default"

Alexander Aring (20):
fs: dlm: plock use list_first_entry
fs: dlm: remove may interrupted message
fs: dlm: add pid to debug log
fs: dlm: change log output to debug again
fs: dlm: use dlm_plock_info for do_unlock_close
fs: dlm: change posix lock sigint handling
fs: dlm: change ast and bast trace order
fs: dlm: remove additional dereference of lkbsb
fs: dlm: add resource name to tracepoints
fs: dlm: add notes for recovery and membership handling
fs: dlm: call dlm_lsop_recover_prep once
fs: dlm: let new_lockspace() wait until recovery
fs: dlm: handle recovery result outside of ls_recover
fs: dlm: handle recovery -EAGAIN case as retry
fs: dlm: change -EINVAL recovery error to -EAGAIN
fs: dlm: add comment about lkb IFL flags
fs: dlm: remove warn waiter handling
fs: dlm: remove timeout from dlm_user_adopt_orphan
fs: dlm: add API deprecation warning
fs: dlm: don't use deprecated API by default

 fs/dlm/Kconfig             |   9 +++
 fs/dlm/Makefile            |   2 +-
 fs/dlm/ast.c               |   4 +-
 fs/dlm/config.c            |  21 ++++--
 fs/dlm/config.h            |   3 +-
 fs/dlm/dir.c               |   4 ++
 fs/dlm/dlm_internal.h      |  32 +++++++--
 fs/dlm/lock.c              | 132 ++++++++++++++-----------------------
 fs/dlm/lock.h              |  17 ++++-
 fs/dlm/lockspace.c         |  31 +++++++--
 fs/dlm/member.c            |  30 ++++-----
 fs/dlm/netlink.c           |   8 +++
 fs/dlm/plock.c             |  51 +++++++++-----
 fs/dlm/recoverd.c          |  60 +++++++++++++++--
 fs/dlm/user.c              |  21 +++++-
 include/trace/events/dlm.h | 118 ++++++++++++++++++++++++++-------
 16 files changed, 378 insertions(+), 165 deletions(-)
Signature · 1 line
2.31.1