RFC net: dsa: microchip: common spi probe for the ksz series switches
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest15 patches 19 repliesIn review
- v1 RFC17 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- Fixed the compilation issue.
- Reduced the patch set to 15.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | net: dsa: microchip: ksz9477: cleanup the ksz9477_switch_detectdrivers/ | +22 | 1 reply | |
| 2/15 | net: dsa: microchip: move switch chip_id detection to ksz_commondrivers/ drivers/ drivers/ +3 more | +92 | 2 replies | |
| 3/15 | net: dsa: microchip: move tag_protocol & phy read/write to ksz_commondrivers/ drivers/ drivers/ +1 more | +38 | 2 replies | |
| 4/15 | net: dsa: microchip: move vlan functionality to ksz_commondrivers/ drivers/ drivers/ +1 more | +72 | 1 reply | |
| 5/15 | net: dsa: microchip: move the port mirror to ksz_commondrivers/ drivers/ drivers/ +1 more | +47 | 2 replies | |
| 6/15 | net: dsa: microchip: get P_STP_CTRL in ksz_port_stp_state by ksz_dev_opsdrivers/ drivers/ drivers/ +1 more | +17 | 2 replies | |
| 7/15 | net: dsa: microchip: update the ksz_phylink_get_capsdrivers/ drivers/ drivers/ +1 more | +11 | 1 reply | |
| 8/15 | net: dsa: microchip: update the ksz_port_mdb_add/deldrivers/ drivers/ drivers/ +1 more | +100 | 1 reply | |
| 9/15 | net: dsa: microchip: update fdb add/del/dump in ksz_commondrivers/ drivers/ drivers/ +1 more | +84 | 2 replies | |
| 10/15 | net: dsa: microchip: move the setup, get_phy_flags & mtu to ksz_commondrivers/ drivers/ drivers/ +1 more | +68 | 2 replies | |
| 11/15 | net: dsa: microchip: common dsa_switch_ops for ksz switchesdrivers/ drivers/ drivers/ +1 more | +89 | 0 replies | |
| 12/15 | net: dsa: microchip: ksz9477: separate phylink mode from switch registerdrivers/ drivers/ drivers/ | +31 | 3 replies | |
| 13/15 | net: dsa: microchip: common menuconfig for ksz series switchdrivers/ drivers/ drivers/ | +13 | 0 replies | |
| 14/15 | net: dsa: microchip: move ksz_dev_ops to ksz_common.cdrivers/ drivers/ drivers/ +7 more | +271 | 0 replies | |
| 15/15 | net: dsa: microchip: common ksz_spi_probe for ksz switchesdrivers/ drivers/ drivers/ +1 more | +69 | 0 replies |
Reviews trailers per patch
5 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Oltean |
|---|---|
| 1/15 | R-b |
| 2/15 | |
| 3/15 | |
| 4/15 | R-b |
| 5/15 | R-b |
| 6/15 | |
| 7/15 | R-b |
| 8/15 | R-b |
| 9/15 | |
| 10/15 | |
| 11/15 | |
| 12/15 | |
| 13/15 | |
| 14/15 | |
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC Patch net-next v2 00/15] net: dsa: microchip: common spi probe for the ksz series switches
This patch series aims to refactor the ksz_switch_register routine to have the common flow for the ksz series switch. At present ksz8795.c & ksz9477.c have its own dsa_switch_ops and switch detect functionality.
In ksz_switch_register, ksz_dev_ops is assigned based on the function parameter passed by the individual ksz8/ksz9477 switch register function. And then switch detect is performed based on the ksz_dev_ops.detect hook. This patch modifies the ksz_switch_register such a way that switch detect is performed first, based on the chip ksz_dev_ops is assigned to ksz_device structure. It ensures the common flow for the existing as well as LAN937x switches.
It also replaces the individual dsa_switch_ops structure to common dsa_switch_ops in the ksz_common. Based on the ksz_dev_ops hook pointer, particular functionality for the switches may or may not executed. Finally replaces the two spi probes such as ksz8795_spi.c and ksz9477_spi.c to common ksz_spi.c. These switches have different regmap config and it is differentited using the of_device_id data.
Changes in RFC v2
- Fixed the compilation issue.
- Reduced the patch set to 15.
Arun Ramadoss (15):
net: dsa: microchip: ksz9477: cleanup the ksz9477_switch_detect
net: dsa: microchip: move switch chip_id detection to ksz_common
net: dsa: microchip: move tag_protocol & phy read/write to ksz_common
net: dsa: microchip: move vlan functionality to ksz_common
net: dsa: microchip: move the port mirror to ksz_common
net: dsa: microchip: get P_STP_CTRL in ksz_port_stp_state by
ksz_dev_ops
net: dsa: microchip: update the ksz_phylink_get_caps
net: dsa: microchip: update the ksz_port_mdb_add/del
net: dsa: microchip: update fdb add/del/dump in ksz_common
net: dsa: microchip: move the setup, get_phy_flags & mtu to ksz_common
net: dsa: microchip: common dsa_switch_ops for ksz switches
net: dsa: microchip: ksz9477: separate phylink mode from switch
register
net: dsa: microchip: common menuconfig for ksz series switch
net: dsa: microchip: move ksz_dev_ops to ksz_common.c
net: dsa: microchip: common ksz_spi_probe for ksz switches
drivers/net/dsa/microchip/Kconfig | 42 +-
drivers/net/dsa/microchip/Makefile | 10 +-
drivers/net/dsa/microchip/ksz8.h | 46 ++
drivers/net/dsa/microchip/ksz8795.c | 309 +++++------
drivers/net/dsa/microchip/ksz8795_reg.h | 13 -
drivers/net/dsa/microchip/ksz8863_smi.c | 2 +-
drivers/net/dsa/microchip/ksz9477.c | 225 ++------
drivers/net/dsa/microchip/ksz9477.h | 58 ++
drivers/net/dsa/microchip/ksz9477_i2c.c | 2 +-
drivers/net/dsa/microchip/ksz9477_reg.h | 1 -
drivers/net/dsa/microchip/ksz9477_spi.c | 150 -----
drivers/net/dsa/microchip/ksz_common.c | 521 +++++++++++++-----
drivers/net/dsa/microchip/ksz_common.h | 91 +--
.../microchip/{ksz8795_spi.c => ksz_spi.c} | 85 ++-
14 files changed, 821 insertions(+), 734 deletions(-)
create mode 100644 drivers/net/dsa/microchip/ksz9477.h
delete mode 100644 drivers/net/dsa/microchip/ksz9477_spi.c
rename drivers/net/dsa/microchip/{ksz8795_spi.c => ksz_spi.c} (61%)Signature · 1 line
2.36.1