Skip to content

KVM/arm64: Refactoring the vcpu flags

Marc Zyngier kvm kvmarm linux-arm-kernel stable 2 versions – Applied

Status from this message: Applied to next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 8 repliesApplied
  2. v118 patches 28 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/19KVM: arm64: Always start with clearing SVE flag on loadarch/arm64/kvm/fpsimd.c+1 -00 replies
2/19KVM: arm64: Always start with clearing SME flag on loadarch/arm64/kvm/fpsimd.c+1 -00 replies
3/19KVM: arm64: Drop FP_FOREIGN_STATE from the hypervisor codearch/arm64/include/asm/kvm_host.h arch/arm64/kvm/fpsimd.c arch/arm64/kvm/hyp/include/hyp/switch.h +2 more+14 -240 replies
4/19KVM: arm64: Move FP state ownership from flag to a tristatearch/arm64/include/asm/kvm_host.h arch/arm64/kvm/fpsimd.c arch/arm64/kvm/hyp/include/hyp/switch.h +2 more+19 -180 replies
5/19KVM: arm64: Add helpers to manipulate vcpu flags among a setarch/arm64/include/asm/kvm_host.h+44 -03 replies
6/19KVM: arm64: Add three sets of flags to the vcpu statearch/arm64/include/asm/kvm_host.h+9 -01 reply
7/19KVM: arm64: Move vcpu configuration flags into their own setarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/reset.c+13 -100 replies
8/19KVM: arm64: Move vcpu PC/Exception flags to the input flag setarch/arm64/include/asm/kvm_emulate.h arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arm.c +3 more+61 -540 replies
9/19KVM: arm64: Move vcpu debug/SPE/TRBE flags to the input flag setarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/debug.c arch/arm64/kvm/hyp/include/hyp/debug-sr.h +3 more+31 -290 replies
10/19KVM: arm64: Move vcpu SVE/SME flags to the state flag setarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/fpsimd.c+11 -90 replies
11/19KVM: arm64: Move vcpu ON_UNSUPPORTED_CPU flag to the state flag setarch/arm64/include/asm/kvm_host.h+5 -42 replies
12/19KVM: arm64: Move vcpu WFIT flag to the state flag setarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arch_timer.c arch/arm64/kvm/arm.c +1 more+5 -50 replies
13/19KVM: arm64: Kill unused vcpu flags fieldarch/arm64/include/asm/kvm_host.h+0 -30 replies
14/19KVM: arm64: Convert vcpu sysregs_loaded_on_cpu to a state flagarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/hyp/vhe/sysreg-sr.c arch/arm64/kvm/sys_regs.c+6 -80 replies
15/19KVM: arm64: Warn when PENDING_EXCEPTION and INCREMENT_PC are set togetherarch/arm64/include/asm/kvm_emulate.h+2 -00 replies
16/19KVM: arm64: Add build-time sanity checks for flagsarch/arm64/include/asm/kvm_host.h+16 -00 replies
17/19KVM: arm64: Reduce the size of the vcpu flag membersarch/arm64/include/asm/kvm_host.h+3 -30 replies
18/19KVM: arm64: Document why pause cannot be turned into a flagarch/arm64/include/asm/kvm_host.h+9 -30 replies
19/19KVM: arm64: Move the handling of !FP outside of the fast patharch/arm64/kvm/arm.c arch/arm64/kvm/fpsimd.c+10 -41 reply

Reviews trailers per patch

18 of 19 patches have a Reviewed-by or Acked-by.

PatchMark BrownReiji WatanabeFuad Tabba
1/19R-b
2/19Reviwed-by
3/19R-b R-b
4/19R-b R-b
5/19R-b R-b
6/19R-b R-b
7/19R-b R-b
8/19R-b R-b
9/19R-b
10/19R-b
11/19R-b
12/19R-b
13/19R-b
14/19R-b
15/19R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/19] KVM/arm64: Refactoring the vcpu flags

This is a iteration on [1], which aims at making the vcpu flags suck a bit less.

* From v1 [1]:
- Rebased onto v5.19-rc1
- Took the first two patches into kvmarm-fixes, included here for completeness
- Additional patch to move system_supports_fpsimd() outside of the run path (Reiji)
- Expanded on comments (Reiji)
- New kvm_pend_exception() accessor (Fuad)
- Various bracketing fixups (Reiji)
- Some renaming (Reiji, Broonie)
- Collected RBs, with thanks

[1] https://lore.kernel.org/r/[email protected]

Marc Zyngier (19):
KVM: arm64: Always start with clearing SVE flag on load
KVM: arm64: Always start with clearing SME flag on load
KVM: arm64: Drop FP_FOREIGN_STATE from the hypervisor code
KVM: arm64: Move FP state ownership from flag to a tristate
KVM: arm64: Add helpers to manipulate vcpu flags among a set
KVM: arm64: Add three sets of flags to the vcpu state
KVM: arm64: Move vcpu configuration flags into their own set
KVM: arm64: Move vcpu PC/Exception flags to the input flag set
KVM: arm64: Move vcpu debug/SPE/TRBE flags to the input flag set
KVM: arm64: Move vcpu SVE/SME flags to the state flag set
KVM: arm64: Move vcpu ON_UNSUPPORTED_CPU flag to the state flag set
KVM: arm64: Move vcpu WFIT flag to the state flag set
KVM: arm64: Kill unused vcpu flags field
KVM: arm64: Convert vcpu sysregs_loaded_on_cpu to a state flag
KVM: arm64: Warn when PENDING_EXCEPTION and INCREMENT_PC are set
together
KVM: arm64: Add build-time sanity checks for flags
KVM: arm64: Reduce the size of the vcpu flag members
KVM: arm64: Document why pause cannot be turned into a flag
KVM: arm64: Move the handling of !FP outside of the fast path

 arch/arm64/include/asm/kvm_emulate.h       |  11 +-
 arch/arm64/include/asm/kvm_host.h          | 203 +++++++++++++++------
 arch/arm64/kvm/arch_timer.c                |   2 +-
 arch/arm64/kvm/arm.c                       |  12 +-
 arch/arm64/kvm/debug.c                     |  25 ++-
 arch/arm64/kvm/fpsimd.c                    |  37 ++--
 arch/arm64/kvm/handle_exit.c               |   2 +-
 arch/arm64/kvm/hyp/exception.c             |  23 ++-
 arch/arm64/kvm/hyp/include/hyp/debug-sr.h  |   6 +-
 arch/arm64/kvm/hyp/include/hyp/switch.h    |  24 +--
 arch/arm64/kvm/hyp/include/hyp/sysreg-sr.h |   4 +-
 arch/arm64/kvm/hyp/nvhe/debug-sr.c         |   8 +-
 arch/arm64/kvm/hyp/nvhe/switch.c           |   6 +-
 arch/arm64/kvm/hyp/nvhe/sys_regs.c         |   4 +-
 arch/arm64/kvm/hyp/vhe/switch.c            |   4 +-
 arch/arm64/kvm/hyp/vhe/sysreg-sr.c         |   4 +-
 arch/arm64/kvm/inject_fault.c              |  17 +-
 arch/arm64/kvm/reset.c                     |   6 +-
 arch/arm64/kvm/sys_regs.c                  |  12 +-
 19 files changed, 248 insertions(+), 162 deletions(-)
Signature · 6 lines
2.34.1

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm