Skip to content

hw/acpi/piix4: remove legacy piix4_pm_init() function

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest11 patches 4 repliesIn review

Changes in v2 from the cover letter

- Addressed Ani & Bernhard review comments

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to piix4_pm_realize()hw/acpi/piix4.c+4 -30 replies
2/11hw/acpi/piix4: change smm_enabled from int to boolhw/acpi/piix4.c include/hw/southbridge/piix.h+3 -30 replies
3/11hw/acpi/piix4: convert smm_enabled bool to qdev propertyhw/acpi/piix4.c+2 -10 replies
4/11hw/acpi/piix4: move PIIX4PMState into separate piix4.h headerhw/acpi/piix4.c hw/i386/acpi-build.c include/hw/acpi/piix4.h +1 more+78 -430 replies
5/11hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMStatehw/acpi/piix4.c hw/i386/pc_piix.c hw/isa/piix4.c +1 more+18 -180 replies
6/11hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn()hw/acpi/piix4.c hw/i386/pc_piix.c hw/isa/piix4.c +1 more+12 -120 replies
7/11hw/acpi/piix4: use qdev gpio to wire up sci_irqhw/acpi/piix4.c hw/i386/pc_piix.c hw/isa/piix4.c +1 more+15 -100 replies
8/11hw/acpi/piix4: use qdev gpio to wire up smi_irqhw/acpi/piix4.c hw/i386/pc_piix.c hw/isa/piix4.c +1 more+6 -50 replies
9/11hw/i386/pc_piix: create PIIX4_PM device directly instead of using piix4_pm_initfn()hw/i386/pc_piix.c+8 -30 replies
10/11hw/isa/piix4.c: create PIIX4_PM device directly instead of using piix4_pm_initfn()hw/isa/piix4.c+7 -40 replies
11/11hw/acpi/piix4: remove unused piix4_pm_initfn() functionhw/acpi/piix4.c include/hw/southbridge/piix.h+0 -230 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéAni SinhaBernhard BeschowMichael S. Tsirkin
SeriesR-b A-b
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/11] hw/acpi/piix4: remove legacy piix4_pm_init() function

From: Philippe Mathieu-Daudé <[email protected]>

This series moves the outstanding logic from piix4_pm_init() into the relevant instance init() and realize() functions, changes the IRQs to use qdev gpios, and then finally removes the now-unused piix4_pm_initfn() function.

v2:
- Addressed Ani & Bernhard review comments

If no further comments I plan to queue this via mips-next end of this week.

Regards,

Phil.

Mark Cave-Ayland (11):
hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to

    piix4_pm_realize()
  hw/acpi/piix4: change smm_enabled from int to bool
  hw/acpi/piix4: convert smm_enabled bool to qdev property
  hw/acpi/piix4: move PIIX4PMState into separate piix4.h header
  hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMState
  hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn()
  hw/acpi/piix4: use qdev gpio to wire up sci_irq
  hw/acpi/piix4: use qdev gpio to wire up smi_irq
  hw/i386/pc_piix: create PIIX4_PM device directly instead of using
    piix4_pm_initfn()
  hw/isa/piix4.c: create PIIX4_PM device directly instead of using
    piix4_pm_initfn()

hw/acpi/piix4: remove unused piix4_pm_initfn() function

 hw/acpi/piix4.c               | 77 ++++++-----------------------------
 hw/i386/acpi-build.c          |  1 +
 hw/i386/pc_piix.c             | 16 +++++---
 hw/isa/piix4.c                | 11 +++--
 include/hw/acpi/piix4.h       | 75 ++++++++++++++++++++++++++++++++++
 include/hw/southbridge/piix.h |  6 ---
 6 files changed, 107 insertions(+), 79 deletions(-)
 create mode 100644 include/hw/acpi/piix4.h
Signature · 1 line
2.36.1