hw/acpi/piix4: remove legacy piix4_pm_init() function
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest11 patches 4 repliesIn review
Changes in v2 from the cover letter
- Addressed Ani & Bernhard review comments
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to piix4_pm_realize()hw/ | +4 | 0 replies | |
| 2/11 | hw/acpi/piix4: change smm_enabled from int to boolhw/ include/ | +3 | 0 replies | |
| 3/11 | hw/acpi/piix4: convert smm_enabled bool to qdev propertyhw/ | +2 | 0 replies | |
| 4/11 | hw/acpi/piix4: move PIIX4PMState into separate piix4.h headerhw/ hw/ include/ +1 more | +78 | 0 replies | |
| 5/11 | hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMStatehw/ hw/ hw/ +1 more | +18 | 0 replies | |
| 6/11 | hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn()hw/ hw/ hw/ +1 more | +12 | 0 replies | |
| 7/11 | hw/acpi/piix4: use qdev gpio to wire up sci_irqhw/ hw/ hw/ +1 more | +15 | 0 replies | |
| 8/11 | hw/acpi/piix4: use qdev gpio to wire up smi_irqhw/ hw/ hw/ +1 more | +6 | 0 replies | |
| 9/11 | hw/i386/pc_piix: create PIIX4_PM device directly instead of using piix4_pm_initfn()hw/ | +8 | 0 replies | |
| 10/11 | hw/isa/piix4.c: create PIIX4_PM device directly instead of using piix4_pm_initfn()hw/ | +7 | 0 replies | |
| 11/11 | hw/acpi/piix4: remove unused piix4_pm_initfn() functionhw/ include/ | +0 | 0 replies |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Philippe Mathieu-Daudé | Ani Sinha | Bernhard Beschow | Michael S. Tsirkin |
|---|---|---|---|---|
| Series | R-b | A-b | ||
| 1/11 | R-b | R-b | ||
| 2/11 | R-b | R-b | ||
| 3/11 | R-b | R-b | ||
| 4/11 | R-b | |||
| 5/11 | R-b | |||
| 6/11 | R-b | |||
| 7/11 | R-b | |||
| 8/11 | R-b | |||
| 9/11 | R-b | |||
| 10/11 | R-b | |||
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 00/11] hw/acpi/piix4: remove legacy piix4_pm_init() function
From: Philippe Mathieu-Daudé <[email protected]>
This series moves the outstanding logic from piix4_pm_init() into the relevant instance init() and realize() functions, changes the IRQs to use qdev gpios, and then finally removes the now-unused piix4_pm_initfn() function.
v2:
- Addressed Ani & Bernhard review comments
If no further comments I plan to queue this via mips-next end of this week.
Regards,
Phil.
Mark Cave-Ayland (11):
hw/acpi/piix4: move xen_enabled() logic from piix4_pm_init() to
piix4_pm_realize()
hw/acpi/piix4: change smm_enabled from int to bool
hw/acpi/piix4: convert smm_enabled bool to qdev property
hw/acpi/piix4: move PIIX4PMState into separate piix4.h header
hw/acpi/piix4: alter piix4_pm_init() to return PIIX4PMState
hw/acpi/piix4: rename piix4_pm_init() to piix4_pm_initfn()
hw/acpi/piix4: use qdev gpio to wire up sci_irq
hw/acpi/piix4: use qdev gpio to wire up smi_irq
hw/i386/pc_piix: create PIIX4_PM device directly instead of using
piix4_pm_initfn()
hw/isa/piix4.c: create PIIX4_PM device directly instead of using
piix4_pm_initfn() hw/acpi/piix4: remove unused piix4_pm_initfn() function
hw/acpi/piix4.c | 77 ++++++----------------------------- hw/i386/acpi-build.c | 1 + hw/i386/pc_piix.c | 16 +++++--- hw/isa/piix4.c | 11 +++-- include/hw/acpi/piix4.h | 75 ++++++++++++++++++++++++++++++++++ include/hw/southbridge/piix.h | 6 --- 6 files changed, 107 insertions(+), 79 deletions(-) create mode 100644 include/hw/acpi/piix4.h
Signature · 1 line
2.36.1