Skip to content

ata,sd: Fix reading concurrent positioning ranges

Tyler Erickson linux-ide linux-scsi stable 2 versions – Applied

Status from this message: Applied to 5.19/scsi-fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 13 repliesApplied
  2. v12 patches 5 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3libata: fix reading concurrent positioning ranges logdrivers/ata/libata-core.c+13 -84 replies
2/3libata: fix translation of concurrent positioning rangesdrivers/ata/libata-scsi.c+1 -11 reply
3/3scsi: sd: Fix interpretation of VPD B9h lengthdrivers/scsi/sd.c+1 -13 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMuhammad AhmadMichael EnglishDamien Le MoalHannes Reinecke
1/3R-b T-b
2/3R-b T-b R-b
3/3R-b T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] ata,sd: Fix reading concurrent positioning ranges

This patch series fixes reading the concurrent positioning ranges.

The first patch fixes reading this in libata, where it was reading more data than a drive necessarily supports, resulting in a command abort.

The second patch fixes the SCSI translated data to put the VPD page length in the correct starting byte.

The third patch in sd, the fix is adding 4 instead of 3 for the header length. Using 3 will always result in an error and was likely used incorrectly as T10 specifications list all tables starting at byte 0, and byte 3 is the page length, which would mean there are 4 total bytes before the remaining data that contains the ranges and other information.

Tyler Erickson (3):
libata: fix reading concurrent positioning ranges log
libata: fix translation of concurrent positioning ranges
scsi: sd: Fix interpretation of VPD B9h length

 drivers/ata/libata-core.c | 21 +++++++++++++--------
 drivers/ata/libata-scsi.c |  2 +-
 drivers/scsi/sd.c         |  2 +-
 3 files changed, 15 insertions(+), 10 deletions(-)

base-commit: 700170bf6b4d773e328fa54ebb70ba444007c702

Signature · 1 line
2.17.1