Skip to content

irqchip: Fix some refcount leaks

Miaoqian Lin linux-arm-kernel lkml 1 version Applied

Status from this message: The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6irqchip/gic/realview: Fix refcount leak in realview_gic_of_initdrivers/irqchip/irq-gic-realview.c+1 -00 replies
2/6irqchip/apple-aic: Fix refcount leak in build_fiq_affinitydrivers/irqchip/irq-apple-aic.c+1 -00 replies
3/6irqchip/apple-aic: Fix refcount leak in aic_of_ic_initdrivers/irqchip/irq-apple-aic.c+1 -00 replies
4/6irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitionsdrivers/irqchip/irq-gic-v3.c+1 -10 replies
5/6irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitionsdrivers/irqchip/irq-gic-v3.c+4 -10 replies
6/6irqchip/realtek-rtl: Fix refcount leak in map_interruptsdrivers/irqchip/irq-realtek-rtl.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] irqchip: Fix some refcount leaks

The following patchset fix some refcount leak bugs in irqchip. The cause of the bugs are missing post handling of some APIs ——of_find_node_by_phandle(),of_find_matching_node_and_match(), of_get_child_by_name().
These APIs returns node pointer with refcount incremented. and should use of_node_put() to release it when not needed anymore.

I've sent patch#1 and patch#2 separately before, I move them into one series for better management. the content of them don't change.

related link:
1. patch#1: https://lore.kernel.org/r/[email protected]/
2. patch#2: https://lore.kernel.org/r/[email protected]/

Miaoqian Lin (6):
irqchip/gic/realview: Fix refcount leak in realview_gic_of_init irqchip/apple-aic: Fix refcount leak in build_fiq_affinity irqchip/apple-aic: Fix refcount leak in aic_of_ic_init irqchip/gic-v3: Fix error handling in gic_populate_ppi_partitions irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions irqchip/realtek-rtl: Fix refcount leak in map_interrupts

 drivers/irqchip/irq-apple-aic.c    | 2 ++
 drivers/irqchip/irq-gic-realview.c | 1 +
 drivers/irqchip/irq-gic-v3.c       | 7 +++++--
 drivers/irqchip/irq-realtek-rtl.c  | 2 +-
 4 files changed, 9 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1