Skip to content

drm/mgag200: Convert device init to use device-info structure

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/mgag200: Remove special case for G200SE with <2 MiBdrivers/gpu/drm/mgag200/mgag200_mode.c+1 -120 replies
2/10drm/mgag200: Initialize each model in separate functiondrivers/gpu/drm/mgag200/Makefile drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h +10 more+603 -2020 replies
3/10drm/mgag200: Move PCI-option setup into model-specific codedrivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c +6 more+100 -550 replies
4/10drm/mgag200: Call mgag200_device_probe_vram() from per-model initdrivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c +9 more+94 -580 replies
5/10drm/mgag200: Implement new init logicdrivers/gpu/drm/mgag200/Makefile drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h +10 more+88 -1480 replies
6/10drm/mgag200: Add struct mgag200_device_infodrivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c +7 more+46 -100 replies
7/10drm/mgag200: Store HW_BUG_NO_STARTADD flag in device infodrivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c +8 more+69 -690 replies
8/10drm/mgag200: Store maximum resolution and memory bandwith in device infodrivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c drivers/gpu/drm/mgag200/mgag200_g200eh.c +7 more+77 -650 replies
9/10drm/mgag200: Store vidrst flag in device infodrivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c drivers/gpu/drm/mgag200/mgag200_g200eh.c +8 more+24 -170 replies
10/10drm/mgag200: Store positions of I2C data and clock bits in device infodrivers/gpu/drm/mgag200/mgag200_drv.h drivers/gpu/drm/mgag200/mgag200_g200.c drivers/gpu/drm/mgag200/mgag200_g200eh.c +7 more+27 -380 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJocelyn Falempe
SeriesR-b T-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] drm/mgag200: Convert device init to use device-info structure

Convert the device-init code to use a device-info structure for each model. The device info contains constants and flags that were previously located in different places of the code.

Also refactor the PCI and VRAM initialization handling. A later patchset could convert the PCI magic numbers into constants.

For modesetting, the per-model init functions currently don't do much. This will change when more model-specific code gets moved there. The modesetting and PLL code contains model-specific handling that should be refactored.

Tested with G200 and G200EV hardware.

Thomas Zimmermann (10):
drm/mgag200: Remove special case for G200SE with <2 MiB drm/mgag200: Initialize each model in separate function drm/mgag200: Move PCI-option setup into model-specific code drm/mgag200: Call mgag200_device_probe_vram() from per-model init drm/mgag200: Implement new init logic
drm/mgag200: Add struct mgag200_device_info
drm/mgag200: Store HW_BUG_NO_STARTADD flag in device info drm/mgag200: Store maximum resolution and memory bandwith in device
info
drm/mgag200: Store vidrst flag in device info
drm/mgag200: Store positions of I2C data and clock bits in device info

 drivers/gpu/drm/mgag200/Makefile          |  14 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c     | 386 ++++++++--------------
 drivers/gpu/drm/mgag200/mgag200_drv.h     | 135 ++++++--
 drivers/gpu/drm/mgag200/mgag200_g200.c    | 200 +++++++++++
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c |  51 +++
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |  46 +++
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |  60 ++++
 drivers/gpu/drm/mgag200/mgag200_g200se.c  | 130 ++++++++
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_i2c.c     |  27 +-
 drivers/gpu/drm/mgag200/mgag200_mm.c      | 116 -------
 drivers/gpu/drm/mgag200/mgag200_mode.c    | 100 ++----
 drivers/gpu/drm/mgag200/mgag200_pll.c     |  12 +-
 drivers/gpu/drm/mgag200/mgag200_reg.h     |   2 +
 16 files changed, 942 insertions(+), 487 deletions(-)
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200eh.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200eh3.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200er.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200ev.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200ew3.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200se.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200wb.c
 delete mode 100644 drivers/gpu/drm/mgag200/mgag200_mm.c

base-commit: 2c8cc5cd20e28afe6b63acb28890e5f57d9bf055
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24

Signature · 1 line
2.36.1