Skip to content

blk-cgroup: Optimize blkcg_rstat_flush()

Waiman Long cgroups linux-block lkml 9 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest3 patches 4 repliesIn review
  2. v93 patches 4 repliesSuperseded
  3. v83 patches 4 repliesSuperseded
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v73 patches10 repliesSuperseded
v63 patches17 repliesSuperseded
v53 patches6 repliesSuperseded
v41 of 2 patches0 repliesSuperseded
v32 patches2 repliesSuperseded
v22 patches8 repliesSuperseded

Changes in v10 from the cover letter

- Update patch 3 to rename the rstat function to cgroup_rstat_css_cpu_flush().

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error pathblock/blk-cgroup.c+4 -80 replies
2/3blk-cgroup: Optimize blkcg_rstat_flush()block/blk-cgroup.c block/blk-cgroup.h+80 -60 replies
3/3blk-cgroup: Flush stats at blkgs destruction pathblock/blk-cgroup.c include/linux/cgroup.h kernel/cgroup/rstat.c+35 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMing LeiTejun Heo
1/3R-b A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 0/3] blk-cgroup: Optimize blkcg_rstat_flush()

v10:
- Update patch 3 to rename the rstat function to cgroup_rstat_css_cpu_flush().

v9:
- Remove patch "llist: Allow optional sentinel node terminated lockless list" for now. This will be done as a follow-up patch.
- Add a new lqueued field to blkg_iostat_set to store the status of whether lnode is in a lockless list.
- Add a new patch 3 to speed up the freeing of blkcg by flushing out the rstat lockless lists at blkcg offline time.

v8:
- Update the llist patch to make existing llist functions and macros work for both NULL and sentinel terminated lockless list as much as possible and leave only the initialization and removal functions to have a sentinel terminated llist variants.

This patch series improves blkcg_rstat_flush() performance by eliminating unnecessary blkg enumeration and flush operations for those blkg's and blkg_iostat_set's that haven't been updated since the last flush.

Waiman Long (3):
blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
blk-cgroup: Optimize blkcg_rstat_flush()
blk-cgroup: Flush stats at blkgs destruction path

 block/blk-cgroup.c     | 103 +++++++++++++++++++++++++++++++++++------
 block/blk-cgroup.h     |  10 ++++
 include/linux/cgroup.h |   1 +
 kernel/cgroup/rstat.c  |  20 ++++++++
 4 files changed, 119 insertions(+), 15 deletions(-)
Signature · 1 line
2.31.1