Skip to content

can: kvaser_usb: CAN clock frequency regression

Jimmy Assarsson linux-can stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v12 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Add struct kvaser_usb_driver_info as suggested by Marc Kleine-Budde [1],

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3can: kvaser_usb: Replace run-time checks with struct kvaser_usb_driver_infodrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+174 -1510 replies
2/3can: kvaser_usb: kvaser_usb_leaf: Fix CAN clock frequency regressiondrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+38 -210 replies
3/3can: kvaser_usb: kvaser_usb_leaf: Fix bittiming limitsdrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+57 -460 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression

When fixing the CAN clock frequency,
fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"), I introduced a regression.

For Leaf devices based on M32C, the firmware expects bittiming parameters calculated for 16MHz clock. Regardless of the actual clock frequency.

This regression affects M32C based Leaf devices with non-16MHz clock.

Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits are different depending on which firmware/device being used.

Once merged to mainline, I'll backport these fixes for the stable kernels.

Changes in v2:
- Add struct kvaser_usb_driver_info as suggested by Marc Kleine-Budde [1],

    instead of adding dev->card_data.quirks.

[1] https://lore.kernel.org/linux-can/[email protected]/T/#maf9cd66c368ce43eb509a27c69d0323cfc776809

Jimmy Assarsson (3):
can: kvaser_usb: Replace run-time checks with struct
kvaser_usb_driver_info
can: kvaser_usb: kvaser_usb_leaf: Fix CAN clock frequency regression
can: kvaser_usb: kvaser_usb_leaf: Fix bittiming limits

 drivers/net/can/usb/kvaser_usb/kvaser_usb.h   |  73 ++++-
 .../net/can/usb/kvaser_usb/kvaser_usb_core.c  | 253 +++++++++---------
 .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c |  14 +-
 .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 119 ++++----
 4 files changed, 255 insertions(+), 204 deletions(-)
Signature · 1 line
2.36.1