Skip to content

ext4: Fix possible fs corruption due to xattr races

Jan Kara linux-ext4 stable 3 versions – Applied

Status from this message: Applied, thanks! (Some slight adjustments were needed to resolve a

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 19 repliesApplied
  2. v210 patches 8 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* Renamed mb_cache_entry_try_delete() to mb_cache_entry_delete_and_get()
* Added Tested-by tag from Ritesh

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10mbcache: Don't reclaim used entriesfs/mbcache.c+9 -14 replies
2/10mbcache: Add functions to delete entry if unusedfs/mbcache.c include/linux/mbcache.h+73 -33 replies
3/10ext4: Remove EA inode entry from mbcache on inode evictionfs/ext4/inode.c fs/ext4/xattr.c fs/ext4/xattr.h+11 -160 replies
4/10ext4: Unindent codeblock in ext4_xattr_block_set()fs/ext4/xattr.c+39 -401 reply
5/10ext4: Fix race when reusing xattr blocksfs/ext4/xattr.c+45 -224 replies
6/10ext2: Factor our freeing of xattr block referencefs/ext2/xattr.c+38 -523 replies
7/10ext2: Unindent codeblock in ext2_xattr_set()fs/ext2/xattr.c+16 -161 reply
8/10ext2: Avoid deleting xattr block that is being reusedfs/ext2/xattr.c+29 -290 replies
9/10mbcache: Remove mb_cache_entry_delete()fs/mbcache.c include/linux/mbcache.h+0 -380 replies
10/10mbcache: Automatically delete entries from cache on freeingfs/mbcache.c include/linux/mbcache.h+55 -772 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchRitesh Harjani
1/10
2/10
3/10
4/10
5/10Reported-and-tested-by
6/10
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 0/10 v3] ext4: Fix possible fs corruption due to xattr races

Hello!

I've noticed this series didn't get merged yet. I was waiting for more review feedback from Ritesh but somehow that didn't happen. So this is the third submission of the series fixing the races of ext4 xattr block reuse with the few changes that have accumulated since v2. Ted, do you think you can add this series to your tree so that we can merge it during the merge window? Thanks!

Changes since v1:
* Reworked the series to fix all corner cases and make API less errorprone.

Changes since v2:
* Renamed mb_cache_entry_try_delete() to mb_cache_entry_delete_and_get()
* Added Tested-by tag from Ritesh

Honza

Previous versions: