Skip to content

vmxnet3: upgrade to version 7

Ronak Doshi lkml netdev 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 0 repliesNew 7 of 8 applied
  2. v28 patches 2 repliesSuperseded
  3. v18 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- use correct byte ordering for ringBufSize

Patches in v3 7 of 8 applied

#Subject and filesSizeRepliesApplied
1/8vmxnet3: prepare for version 7 changesdrivers/net/vmxnet3/Makefile drivers/net/vmxnet3/upt1_defs.h drivers/net/vmxnet3/vmxnet3_defs.h +3 more+9 -60 repliesApplied
2/8vmxnet3: add support for capability registersdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_ethtool.c +1 more+233 -60 repliesApplied
3/8vmxnet3: add support for large passthrough BAR registerdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_ethtool.c +1 more+38 -100 repliesApplied
4/8vmxnet3: add support for out of order rx completiondrivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_int.h+63 -120 repliesApplied
5/8vmxnet3: add command to set ring buffer sizesdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_ethtool.c +1 more+65 -130 replies
6/8vmxnet3: limit number of TXDs used for TSO packetdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c+19 -00 repliesApplied
7/8vmxnet3: use ext1 field to indicate encapsulated packetdrivers/net/vmxnet3/vmxnet3_defs.h drivers/net/vmxnet3/vmxnet3_drv.c+23 -90 repliesApplied
8/8vmxnet3: update to version 7drivers/net/vmxnet3/vmxnet3_drv.c drivers/net/vmxnet3/vmxnet3_int.h+8 -30 repliesApplied

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchGuolin Yang
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/8] vmxnet3: upgrade to version 7

vmxnet3 emulation has recently added several new features including support for uniform passthrough(UPT). To make UPT work vmxnet3 has to be enhanced as per the new specification. This patch series extends the vmxnet3 driver to leverage these new features.

Compatibility is maintained using existing vmxnet3 versioning mechanism as follows:
- new features added to vmxnet3 emulation are associated with new vmxnet3 version viz. vmxnet3 version 7.
- emulation advertises all the versions it supports to the driver.
- during initialization, vmxnet3 driver picks the highest version number supported by both the emulation and the driver and configures emulation to run at that version.

In particular, following changes are introduced:

Patch 1:
This patch introduces utility macros for vmxnet3 version 7 comparison and updates Copyright information.

Patch 2:
This patch adds new capability registers to fine control enablement of individual features based on emulation and passthrough.

Patch 3:
This patch adds support for large passthrough BAR register.

Patch 4:
This patch adds support for out of order rx completion processing.

Patch 5:
This patch introduces new command to set ring buffer sizes to pass this information to the hardware.

Patch 6:
For better performance, hardware has a requirement to limit number of TSO descriptors. This patch adds that support.

Patch 7:
With vmxnet3 version 7, new descriptor fields are used to indicate encapsulation offload.

Patch 8:
With all vmxnet3 version 7 changes incorporated in the vmxnet3 driver, with this patch, the driver can configure emulation to run at vmxnet3 version 7.

Changes in v2->v3:
- use correct byte ordering for ringBufSize

Changes in v2:
- use local rss_fields variable for the rss capability checks in patch 2

Ronak Doshi (8):
vmxnet3: prepare for version 7 changes
vmxnet3: add support for capability registers
vmxnet3: add support for large passthrough BAR register
vmxnet3: add support for out of order rx completion
vmxnet3: add command to set ring buffer sizes
vmxnet3: limit number of TXDs used for TSO packet
vmxnet3: use ext1 field to indicate encapsulated packet
vmxnet3: update to version 7

 drivers/net/vmxnet3/Makefile          |   2 +-
 drivers/net/vmxnet3/upt1_defs.h       |   2 +-
 drivers/net/vmxnet3/vmxnet3_defs.h    |  80 ++++++++--
 drivers/net/vmxnet3/vmxnet3_drv.c     | 291 ++++++++++++++++++++++++++++++----
 drivers/net/vmxnet3/vmxnet3_ethtool.c | 116 ++++++++++++--
 drivers/net/vmxnet3/vmxnet3_int.h     |  24 ++-
 6 files changed, 457 insertions(+), 58 deletions(-)
Signature · 1 line
2.11.0